Skip to content

Commit 18307f0

Browse files
committed
feat: add members option in bottom sheet dialog
1 parent c9716ba commit 18307f0

File tree

5 files changed

+9
-1
lines changed

5 files changed

+9
-1
lines changed

owncloudApp/src/main/java/com/owncloud/android/extensions/SpaceMenuOptionExt.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ fun SpaceMenuOption.toStringResId() =
3131
SpaceMenuOption.ENABLE -> R.string.enable_space
3232
SpaceMenuOption.DELETE -> R.string.delete_space
3333
SpaceMenuOption.SET_ICON -> R.string.set_space_icon
34+
SpaceMenuOption.MEMBERS -> R.string.space_members
3435
}
3536

3637
fun SpaceMenuOption.toDrawableResId() =
@@ -41,4 +42,5 @@ fun SpaceMenuOption.toDrawableResId() =
4142
SpaceMenuOption.ENABLE -> R.drawable.ic_enable_space
4243
SpaceMenuOption.DELETE -> R.drawable.ic_action_delete_white
4344
SpaceMenuOption.SET_ICON -> R.drawable.ic_set_space_icon
45+
SpaceMenuOption.MEMBERS -> R.drawable.ic_share_generic_white
4446
}

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,7 @@ class SpacesListFragment :
461461
val setIconDialog = SetSpaceIconDialogFragment.newInstance(listener = this@SpacesListFragment)
462462
setIconDialog.show(requireActivity().supportFragmentManager, DIALOG_SET_ICON)
463463
}
464+
SpaceMenuOption.MEMBERS -> { }
464465
}
465466
}
466467
}

owncloudApp/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -875,6 +875,7 @@
875875
<string name="delete_space_correctly">Space deleted correctly</string>
876876
<string name="delete_space_failed">Space could not be deleted</string>
877877
<string name="set_space_icon">Set icon</string>
878+
<string name="space_members">Members</string>
878879

879880
<string name="feedback_dialog_get_in_contact_description"><![CDATA[ Ask for help in our <a href=\"%1$s\"><b>forum</b></a> or contribute in our <a href=\"%2$s\"><b>GitHub repo</b></a>]]></string>
880881

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/SpaceMenuOption.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
package com.owncloud.android.domain.spaces.model
2222

2323
enum class SpaceMenuOption {
24-
EDIT, EDIT_IMAGE, DISABLE, ENABLE, DELETE, SET_ICON
24+
EDIT, EDIT_IMAGE, DISABLE, ENABLE, DELETE, SET_ICON, MEMBERS
2525
}

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/FilterSpaceMenuOptionsUseCase.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ class FilterSpaceMenuOptionsUseCase(
4545

4646
val editImagePermission = hasSpacePermission(spacePermissionsResult, DRIVES_MANAGE_PERMISSION)
4747

48+
if (spacePermissionsResult is UseCaseResult.Success) {
49+
optionsToShow.add(SpaceMenuOption.MEMBERS)
50+
}
51+
4852
if (editPermission || isSpaceManager) {
4953
optionsToShow.add(SpaceMenuOption.EDIT)
5054
}

0 commit comments

Comments
 (0)