[BUG] Apply read permission to the list of members instead of the main option

[jesmrec]

From #4763

Current: if the user lacks of libre.graph/driveItem/permissions/read , Members option in the list is hidden. That makes the permalink not to be accessible (it should).

In order to make the permalink always accessible:

• Applying the permission to the list inside the members view
• Moving the permalink to somewhere else

I'd go for the first one, but, this is open to discussion

[corevibe555]

@jesmrec I think I have better suggestions for UX.

1. Move space permalink to the Space menu.

2. Change "Members" menu to "Space Link".When we click on "Space Link", user will be able to see follow screen.(Change title,hide members fragment, show public links)

3. If user has Read permission, everything should be the same as it was.

Let me know what works better, I will improve UX.

[jesmrec]

Thanks for your feedback @corevibe555 .

1. This is something we considered, but, in other features of the app the links are inside and not out, over the menu. For consistency, we kept this in the same place as others.

2. Members is the agreed name in terms of product, you can find it also in other clients over the platform. Also, in the same view, the first list is the members list.

3. If user has Read permission, no changes are expected, that's right. But, it's our current way. Do i miss something?

[corevibe555]

Thanks for the response @jesmrec

1. Got your point about the consistency for the product. Keeping consistency makes sense.
2. For members list, I am currently showing empty list in case of no read permission. I can add "You don’t have access to view the users." instead of empty list. Is this expected?
3. Yes, it's the app's current feature, I am confirming I should not make any regression on the existing feature. Nothing missing.

[joragua]

Just to clarify @corevibe555: Members view includes space members and space public links, so I wouldn't go for the approach you mentioned above. In other words: the permission libre.graph/driveItem/permissions/read also applies to space public links. If the user doesn't have this permission, both sections (space members and links) should not be displayed. I've just checked the PR and I'm missing the logic for the public links. Let us know if you have any question about it and we'll help you! 😄

[corevibe555]

Roger that @joragua I am on it.

[corevibe555]

@joragua Updated as per the feedback. Thanks