feat(search-input): pf-search-input element#2899
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 27c9694 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
ArathyKumar
requested review from
adamjohnson,
bennypowers,
hellogreg and
markcaron
Contributor
Contributor
adamjohnson
requested changes
Apr 8, 2025
adamjohnson
left a comment
adamjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Some considerations to ponder:
- Right now this is feeling more like a
<select>instead of<input type="search">. What actions can we take to make it feel more search like?- eg: adding submit button for search, form element inclusion, click to submit query...
- With Chromium leading the way with customizable selects, should this element try to utilize that API and wait to merge until that feature is stable?
- Have you considered trying to build on top of the
<datalist>element? Would the features coming to customizable selects help the case to use a<datalist>element?
I have to hand it to you Arathy: you go for the most complex components straight out of the gate! 😅
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This comment has been minimized.
This comment has been minimized.
bennypowers
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Developed the
pf-search-inputcomponent by leveraging thepf-selectautocomplete variant to enhance the search functionality and improve user experience.Testing Instructions