CI: build and test with valgrind memory checker too

Amongst others, this catches uninitialized memory access, which libasan
does not.

Signed-off-by: Jonas Rebmann <[email protected]>

Author: jonrebm

.github/workflows/build.yml

@@ -20,25 +20,61 @@ jobs:
             libreadline6-dev \
             autoconf \
             automake \
-            python3-pytest
+            python3-pytest \
+            valgrind
 
       - name: Prepare (autoreconf)
         run: autoreconf -i
 
-      - name: Prepare (configure)
+      # Build 1: ASAN
+      - name: Create ASAN build directory
+        run: mkdir -p build-asan
+
+      - name: Configure ASAN build
+        working-directory: build-asan
         env:
           CFLAGS: "-g -O2 -Wpedantic -Werror -Wno-error=unused-result -fsanitize=address,undefined -fno-omit-frame-pointer"
           LDFLAGS: "-fsanitize=address,undefined"
-        run: ./configure
+        run: ../configure
 
-      - name: Build
+      - name: Build ASAN
+        working-directory: build-asan
         run: make
 
-      - name: Run pytest
+      - name: Run pytest with ASAN
+        continue-on-error: true
+        env:
+          ASAN_OPTIONS: "detect_leaks=1"
+          UBSAN_OPTIONS: "print_stacktrace=1"
+        run: pytest -v --cmd="build-asan/microcom"
+
+      - name: Run check with ASAN
+        continue-on-error: true
+        working-directory: build-asan
         env:
           ASAN_OPTIONS: "detect_leaks=1"
           UBSAN_OPTIONS: "print_stacktrace=1"
-        run: pytest -v
+        run: make check
+
+      # Build 2: Valgrind
+      - name: Create unoptimized build directory
+        run: mkdir -p build-unopt
+
+      - name: Configure unoptimized build
+        working-directory: build-unopt
+        env:
+          CFLAGS: "-g -O0 -Wpedantic -Werror -Wno-error=unused-result"
+        run: ../configure
+
+      - name: Build unoptimized
+        working-directory: build-unopt
+        run: make
+
+      - name: Run pytest with Valgrind
+        continue-on-error: true
+        run: pytest -v --cmd="valgrind --tool=memcheck --error-exitcode=99 --quiet build-unopt/microcom"
 
-      - name: Run check
+      - name: Run check with Valgrind
+        continue-on-error: true
+        working-directory: build-unopt
         run: make check

test/test_telnet.py

@@ -54,7 +54,7 @@ def run():
                 break
         os.close(master_fd)
         proc.wait()
-        assert proc.returncode in (0, 1), f"Exit code must be 0 or 1, got {proc.returncode}"
+        assert proc.returncode in (0, 1)
 
         return bytes(output)
     return _recv