From 350c12beb70a8d8d2035fed86d0b01551843140e Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Wed, 12 Aug 2026 15:39:23 -0700
Subject: [PATCH] Fix inconsistencies

---
 composer.json                            | 4 ++--
 migrations/add_popup_prompt.php          | 4 ++--
 migrations/add_user_popup_preference.php | 6 +++---
 migrations/fix_acp_module_auth.php       | 2 +-
 migrations/handle_subscriptions.php      | 2 +-
 migrations/setup_site_icons.php          | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/composer.json b/composer.json
index 4e2b3af..6b7d024 100644
--- a/composer.json
+++ b/composer.json
@@ -22,8 +22,8 @@
             "role": "Extensions Development Team Lead"
         },
         {
-			"name": "Vinny",
-			"role": "Customisations Team"
+            "name": "Vinny",
+            "role": "Customisations Team"
         }
     ],
     "require": {
diff --git a/migrations/add_popup_prompt.php b/migrations/add_popup_prompt.php
index 98ba3cd..1bf032e 100644
--- a/migrations/add_popup_prompt.php
+++ b/migrations/add_popup_prompt.php
@@ -14,7 +14,7 @@
 
 class add_popup_prompt extends migration
 {
-	public function effectively_installed()
+	public function effectively_installed(): bool
 	{
 		return $this->config->offsetExists('wpn_webpush_popup_prompt');
 	}
@@ -24,7 +24,7 @@ public static function depends_on()
 		return ['\phpbb\webpushnotifications\migrations\add_acp_configs'];
 	}
 
-	public function update_data()
+	public function update_data(): array
 	{
 		return [
 			['config.add', ['wpn_webpush_popup_prompt', 0]],
diff --git a/migrations/add_user_popup_preference.php b/migrations/add_user_popup_preference.php
index d6649d1..6b32443 100644
--- a/migrations/add_user_popup_preference.php
+++ b/migrations/add_user_popup_preference.php
@@ -14,7 +14,7 @@
 
 class add_user_popup_preference extends migration
 {
-	public function effectively_installed()
+	public function effectively_installed(): bool
 	{
 		return $this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_wpn_popup_disabled');
 	}
@@ -24,7 +24,7 @@ public static function depends_on()
 		return ['\phpbb\webpushnotifications\migrations\add_popup_prompt'];
 	}
 
-	public function update_schema()
+	public function update_schema(): array
 	{
 		return [
 			'add_columns'	=> [
@@ -35,7 +35,7 @@ public function update_schema()
 		];
 	}
 
-	public function revert_schema()
+	public function revert_schema(): array
 	{
 		return [
 			'drop_columns'	=> [
diff --git a/migrations/fix_acp_module_auth.php b/migrations/fix_acp_module_auth.php
index 076f203..2ae3458 100644
--- a/migrations/fix_acp_module_auth.php
+++ b/migrations/fix_acp_module_auth.php
@@ -14,7 +14,7 @@
 
 class fix_acp_module_auth extends migration
 {
-	public function effectively_installed()
+	public function effectively_installed(): bool
 	{
 		$sql = 'SELECT module_id
 			FROM ' . $this->table_prefix . "modules
diff --git a/migrations/handle_subscriptions.php b/migrations/handle_subscriptions.php
index 34c842e..496802d 100644
--- a/migrations/handle_subscriptions.php
+++ b/migrations/handle_subscriptions.php
@@ -19,7 +19,7 @@ public static function depends_on()
 		return ['\phpbb\webpushnotifications\migrations\add_webpush'];
 	}
 
-	public function effectively_installed()
+	public function effectively_installed(): bool
 	{
 		return !$this->db_tools->sql_table_exists($this->table_prefix . 'wpn_notification_push');
 	}
diff --git a/migrations/setup_site_icons.php b/migrations/setup_site_icons.php
index 59ab98b..15341b2 100644
--- a/migrations/setup_site_icons.php
+++ b/migrations/setup_site_icons.php
@@ -22,7 +22,7 @@ class setup_site_icons extends container_aware_migration
 	/** @var filesystem $filesystem */
 	private $filesystem;
 
-	public function effectively_installed()
+	public function effectively_installed(): bool
 	{
 		return $this->get_filesystem()->exists($this->container->getParameter('core.root_path') . self::NEW_ICON_DIR);
 	}