cloud: update docs for BYOC single AZ support - #23591
Conversation
ti-chi-bot
Bot
added
contribution
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughBYOC documentation now describes selectable Zonal and Regional high availability modes for resource pools, availability zone requirements, Pool vCPU Limit behavior, mode inheritance, and immutable placement settings. ChangesBYOC high availability
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The documentation adds single-AZ BYOC guidance, but the restore instructions still omit the requirement that Regional resource pools have at least three eligible availability zones. This could mislead operators during restore planning, so the PR is mergeable with explicit owner follow-up to clarify both notes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 070ab6e7-407b-4394-8bbc-082a18f07ee0
📒 Files selected for processing (8)
tidb-cloud/architecture-concepts.mdtidb-cloud/byoc/byoc-initialize-service.mdtidb-cloud/byoc/byoc-prepare-environment-aws.mdtidb-cloud/byoc/create-resource-pool-byoc.mdtidb-cloud/byoc/create-tidb-instance-byoc.mdtidb-cloud/byoc/manage-resource-pools-byoc.mdtidb-cloud/byoc/multi-region-deployment.mdtidb-cloud/premium/backup-and-restore-premium.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
qiancai
changed the title
qiancai
added
translation/no-need
ti-chi-bot
Bot
removed
the
missing-translation-status
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| Once the access keys are configured, you can initiate the restore job from the TiDB Cloud console. | ||
|
|
||
| During restore, select an active resource pool in the target cloud provider and region. | ||
| During restore, select an active resource pool in the target cloud provider and region. The restored instance inherits the high availability mode of the selected resource pool. |
There was a problem hiding this comment.
| During restore, select an active resource pool in the target cloud provider and region. The restored instance inherits the high availability mode of the selected resource pool. | |
| During restore, select an active resource pool in the target cloud provider and region. The restored {{{ .byoc }}} instance inherits the high availability mode of the selected resource pool. |
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Cheng Weiwei <65707268+wildpcww@users.noreply.github.com>
ti-chi-bot
Bot
added
size/XXL
ti-chi-bot
Bot
added
size/M
|
@wildpcww: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit