Nativo: Add optional placementId parameter and Prebid Renderer in response#4380
Nativo: Add optional placementId parameter and Prebid Renderer in response#4380CTMBNara merged 12 commits intoprebid:masterfrom
Conversation
|
@CTMBNara these failing checks seem not related to my changes. Is there any way to re-run them? |
|
@rafataveira Duplicate bidder 'adsinteractive'. Please check the configuration |
@osulzhenko this might have come from a merge issue. I've fixed it. |
|
@CTMBNara Do we have an ETA for reviewing and merging this PR? We have clients waiting on these changes. Thanks! |
|
@CTMBNara I see the errors in the pipeline but I can not replicate it and everything runs good on my side. Can you please explain what is wrong? |
|
@CTMBNara Just checking if you have an ETA for reviewing and merging this PR. We have clients blocked on these changes, so any update would be appreciated. Thank you! |
|
@osulzhenko Is there any ETA for this PR to be reviewed/merged? Thank you! |
Hey, @rafataveira . I'll reply instead. We are done with reviews and will merge this PR when we'll get to merging things in preparations of the next release. We are focusing on 4.0 right now though, so this might take a bit longer than usual. |
|
@Net-burst Thank you for letting me know. We are looking forward to it. |
This pull request adds native support for the Nativo bidder to the codebase, moving it from a generic alias-based configuration to a dedicated, fully integrated bidder module. The changes include the implementation of the Nativo bidder logic, configuration, schema, and integration tests, as well as the removal of the old alias-based approach.
Nativo Bidder Integration:
NativoBidderclass, handling bid requests and responses, bid extension updates, and error handling. (NativoBidder.java)ExtImpNativo. (ExtImpNativo.java)NativoConfiguration.java)nativo.yaml)nativo.json)Testing and Documentation:
NativoTest.java,test-auction-nativo-request.json,test-auction-nativo-response.json,test-nativo-bid-request.json,test-nativo-bid-response.json) [1] [2] [3] [4] [5]Configuration and Cleanup:
generic.yaml,test-application.properties,PbsConfig.groovy,BidderParamsSpec.groovy) [1] [2] [3] [4] [5]These changes ensure that Nativo is now a first-class, configurable bidder in the system, with dedicated code, configuration, validation, and tests.
Schema validation:
nativo.jsonto define and validate the parameters accepted by the Nativo adapter.🔧 Type of changes
✨ What's the context?
Adding optional property "placementId" to Nativo Adapter
Adding SDK Renderer Version in Response
🧠 Rationale behind the change
We have already been using this property, but it wasn't correctly documented in the adapter.
Our mobile ad formats need the Prebid Renderer name and version to work.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Added all the necessary tests.
🏎 Quality check