Skip to content

Attempt to clarify environment marker evaluation #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ncoghlan wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Attempt to clarify environment marker evaluation #1988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b95c27
Attempt to clarify environment marker evaluation
ncoghlan Jan 10, 2026
28d4b58
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 10, 2026
fd2c2e2
Updates from my own PR review
ncoghlan Jan 24, 2026
a50bb27
Use string containment on version-or-string fields
ncoghlan Jan 24, 2026
2cc0701
Fix marker field in macOS release check
ncoghlan Jan 24, 2026
bc46f2d
Add history entries to pages with updated links
ncoghlan Jan 24, 2026
c794ba3
Merge branch 'main' into clarify-environment-marker-comparisons
ncoghlan Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions source/specifications/core-metadata.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,14 +574,14 @@ The format of a requirement string contains from one to four parts:
* An environment marker after a semicolon. This means that the
requirement is only needed in the specified conditions.

See :pep:`508` for full details of the allowed format.

The project names should correspond to names as found
on the `Python Package Index`_.

Version specifiers must follow the rules described in
:doc:`version-specifiers`.

See :ref:`dependency-specifiers` for full details of the allowed format.

Examples::

Requires-Dist: pkginfo
Expand Down Expand Up @@ -1071,6 +1071,9 @@ History
- October 2025: Clarified that ``License-Expression`` applies to the containing
distribution file and not the project itself.

- January 2026: Replaced outdated direct reference to :pep:`508` with a
reference to :ref:`dependency-specifiers`.

----

.. [1] reStructuredText markup:
Expand Down
4 changes: 2 additions & 2 deletions source/specifications/dependency-groups.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ The output is therefore valid ``requirements.txt`` data.
realized_group = []
for item in raw_group:
if isinstance(item, str):
# packaging.requirements.Requirement parsing ensures that this is a valid
# PEP 508 Dependency Specifier
# packaging.requirements.Requirement parsing ensures that this
# is a valid dependency specifier
# raises InvalidRequirement on failure
Requirement(item)
realized_group.append(item)
Expand Down
Loading