Skip to content

Comments

Fix async_alert to respect allow_style setting for 3.x branch#1582

Merged
tleonhardt merged 2 commits into3.xfrom
async-allow_style
Feb 21, 2026
Merged

Fix async_alert to respect allow_style setting for 3.x branch#1582
tleonhardt merged 2 commits into3.xfrom
async-allow_style

Conversation

@tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Feb 21, 2026

This PR fixes the async_alert method and other methods which use it such as async_update_prompt so that it respects the allow_style settable and strips out ANSI escape codes when allow_style is NEVER.

This closes #1581

We will need to make equivalent changes on the main branch after this merges to the 3.x branch but it won't be from a simple cherry-pick.

@tleonhardt tleonhardt self-assigned this Feb 21, 2026
@github-actions
Copy link
Contributor

🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3.x@e228018). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             3.x    #1582   +/-   ##
======================================
  Coverage       ?   99.23%           
======================================
  Files          ?       21           
  Lines          ?     4844           
  Branches       ?        0           
======================================
  Hits           ?     4807           
  Misses         ?       37           
  Partials       ?        0           
Flag Coverage Δ
unittests 99.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

🤖 I'm sorry @tleonhardt, but I was unable to process your request. Please see the logs for more details.

Copy link
Member

@kmvanbrunt kmvanbrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but don't cherry pick this into main since I'm rewriting the async_alert code for 4.x.

@tleonhardt
Copy link
Member Author

@kmvanbrunt I'll merge this into the 3.x branch and won't cherry-pick it to main since you are in the middle of re-writing the async_alert code for 4.x. Please make sure the new code respects that allow_style setting.

@tleonhardt tleonhardt merged commit 32dcb3d into 3.x Feb 21, 2026
28 checks passed
@tleonhardt tleonhardt deleted the async-allow_style branch February 21, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants