tz not taken into account when calling pendulum.instance #841

Activity

1. stripedpumpkin commented on Oct 8, 2024

   

   stripedpumpkin

   on Oct 8, 2024

   More actions

   I think what you need is

   pendulum.now().in_timezone('Europe/Brussels')
   

   or even if actually using #now you can do directly

   pendulum.now(tz='Europe/Brussels')
   

   The instance method is I believe more intended for datetime.datetime conversion (into pendulum.Datetime).
2. RobbertDM commented on Oct 8, 2024

   

   RobbertDM

   on Oct 8, 2024

   Author

   More actions

   Yeah we already have our fix, I just wanted to report this behavior by the instance method, because I don't understand why there is a tz argument if it's not used? This caused a bug earlier in our code because we thought the pendulum.Datetime object that would come out of pendulum.instance(dt, tz='EST') would've been one with tzinfo=Timezone('EST') but it's not.
3. stripedpumpkin commented on Oct 8, 2024

   

   stripedpumpkin

   on Oct 8, 2024

   More actions

   My best guess is that pendulum.instance expects a datetime.datetime with a tzinfo attributes, not a pendulum.Datetime, as the point of #instance is to get a pendulum.Datetime, from a datetime.datetime I think.
4. stripedpumpkin commented on Oct 8, 2024

   

   stripedpumpkin

   on Oct 8, 2024

   Last edited by stripedpumpkin

   More actions

   Ah ok here is what happens:

       @classmethod
       def instance(
           cls,
           dt: datetime.datetime,
           tz: str | Timezone | FixedTimezone | datetime.tzinfo | None = UTC,
       ) -> Self:
           tz = dt.tzinfo or tz
   
           if tz is not None:
               tz = pendulum._safe_timezone(tz, dt=dt)
   

   If you pass a pendulum DateTime as argument it will have a tzinfo, so this will take priority over the one you injected. But again I don't think this method is intended to perform time zone conversions as discussed above.