Address review

Author: ByteFlowing1337

Lib/test/test_free_threading/test_types.py

@@ -1,12 +1,9 @@
 import unittest
-import threading
 from typing import TypeVar
 from test.support import threading_helper
 
 threading_helper.requires_working_threading(module=True)
 
-NTHREADS = 10
-
 
 class TestGenericAlias(unittest.TestCase):
     def test_parameters_race(self):
@@ -31,24 +28,6 @@ def refresh():
             *[refresh for _ in range(2)],
         ])
 
-    def test_shared_generic_alias_iter(self):
-        # See https://github.com/python/cpython/issues/154043
-        def worker(it, barrier):
-            barrier.wait()
-            try:
-                next(it)
-            except StopIteration:
-                pass
-                bar = threading.Barrier(NTHREADS)
-
-        bar = threading.Barrier(NTHREADS)
-        number_of_iterations = 50
-        for _ in range(number_of_iterations):
-            shared = iter(list[int])
-            threading_helper.run_concurrently(
-                worker_func=worker, nthreads=NTHREADS, args=(shared, bar)
-            )
-
 
 if __name__ == "__main__":
     unittest.main()

Objects/genericaliasobject.c

@@ -951,12 +951,11 @@ ga_iternext(PyObject *op)
     }
     gaobject *alias = (gaobject *)obj;
     PyObject *starred_alias = Py_GenericAlias(alias->origin, alias->args);
+    Py_DECREF(obj);
     if (starred_alias == NULL) {
-        Py_DECREF(obj);
         return NULL;
     }
     ((gaobject *)starred_alias)->starred = true;
-    Py_SETREF(obj, NULL);
     return starred_alias;
 }