Commit 7cd5807
committed
gh-154904: Speed up import of shutil by probing compression extensions
shutil imported bz2, lzma and compression.zstd at module scope only to set
the _*_SUPPORTED flags, then discarded the bindings. Executing those pure
Python wrappers also pulled in compression._common[._streams] and
compression.zstd._zstdfile, a cost paid by every program that imports
shutil even if it never touches an archive.
Their only importable dependency that may be missing is the extension
module each one wraps, so probe _bz2, _lzma and _zstd directly instead.
This keeps the exact ImportError semantics of the previous code -- unlike
a find_spec() check, which resolves the always-present wrapper and would
report success on builds where the extension fails to load. The wrappers
are still imported by tarfile/zipfile when an archive is actually created
or extracted.
Cuts the net cost of "import shutil" by ~2.5 ms (-19.6%) and of
"import urllib.request" by ~2.3 ms (-6.4%).1 parent 49f9667 commit 7cd5807
3 files changed
Lines changed: 51 additions & 6 deletions
File tree
- Lib
- test
- Misc/NEWS.d/next/Library
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
21 | 26 | | |
22 | | - | |
23 | | - | |
| 27 | + | |
| 28 | + | |
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
29 | | - | |
30 | | - | |
| 34 | + | |
| 35 | + | |
31 | 36 | | |
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
35 | 40 | | |
36 | | - | |
37 | | - | |
| 41 | + | |
| 42 | + | |
38 | 43 | | |
39 | 44 | | |
40 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
2321 | 2323 | | |
2322 | 2324 | | |
2323 | 2325 | | |
| 2326 | + | |
| 2327 | + | |
| 2328 | + | |
| 2329 | + | |
| 2330 | + | |
| 2331 | + | |
| 2332 | + | |
| 2333 | + | |
| 2334 | + | |
| 2335 | + | |
| 2336 | + | |
| 2337 | + | |
| 2338 | + | |
| 2339 | + | |
| 2340 | + | |
| 2341 | + | |
| 2342 | + | |
| 2343 | + | |
| 2344 | + | |
| 2345 | + | |
| 2346 | + | |
| 2347 | + | |
| 2348 | + | |
| 2349 | + | |
| 2350 | + | |
| 2351 | + | |
| 2352 | + | |
| 2353 | + | |
| 2354 | + | |
| 2355 | + | |
| 2356 | + | |
| 2357 | + | |
| 2358 | + | |
| 2359 | + | |
2324 | 2360 | | |
2325 | 2361 | | |
2326 | 2362 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
0 commit comments