Skip to content

Commit f2507a5

Browse files
committed
Fix tests to actually validate custom message
1 parent e5bb17e commit f2507a5

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

Lib/test/test_exceptions.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2069,7 +2069,11 @@ def __getattr__(self, name):
20692069

20702070
self._test_generated_message(RaiseWithName(), "missing1")
20712071
self._test_generated_message(BareRaise(), "missing2")
2072-
self._test_generated_message(RaiseCustom(), "custom")
2072+
2073+
with self.assertRaises(AttributeError) as cm:
2074+
getattr(RaiseCustom(), "missing3")
2075+
self.assertEqual(str(cm.exception), "custom")
2076+
20732077

20742078
def test_module_getattr_error_message(self):
20752079
mod1 = ModuleType("raisewithname")
@@ -2089,7 +2093,10 @@ def raise_custom(name):
20892093

20902094
self._test_generated_message(mod1, "missing3")
20912095
self._test_generated_message(mod2, "missing4")
2092-
self._test_generated_message(mod3, "custom")
2096+
2097+
with self.assertRaises(AttributeError) as cm:
2098+
getattr(mod3, "missing3")
2099+
self.assertEqual(str(cm.exception), "custom")
20932100

20942101
# Note: name suggestion tests live in `test_traceback`.
20952102

0 commit comments

Comments
 (0)