Skip to content

Review validation of src/href #9

Description

@encukou

Currently the code rejects links that .startswith("javascript:"). This is blacklisting. Blacklisting is bad.
We'll want to whitelist only things like http://, https://, and data:// with specific mimetypes.

Consider: <a href="javaScript:alert('gotcha')">click here</a>.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions