Skip to content

Commit b053151

Browse files
authored
fix: add data attribute in baseFilterChip (#3038)
* fix: add data attribute in baseFilterChip * fix: add changeset * fix: add testId
1 parent e1c4463 commit b053151

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.changeset/gentle-beans-collect.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@razorpay/blade': minor
3+
---
4+
5+
feat(blade): add data attribute in basefilter chip

packages/blade/src/components/FilterChip/BaseFilterChip.web.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ const _BaseFilterChip: React.ForwardRefRenderFunction<BladeElementRef, BaseFilte
149149
})}
150150
{...getStyledProps(rest)}
151151
{...makeAnalyticsAttribute(rest)}
152-
{...metaAttribute({ testID: rest.testID })}
152+
{...metaAttribute({ name: 'filter-chip-trigger', testID: rest.testID })}
153153
>
154154
<Box display="flex" gap="spacing.2" whiteSpace="nowrap">
155155
<Text
@@ -175,6 +175,7 @@ const _BaseFilterChip: React.ForwardRefRenderFunction<BladeElementRef, BaseFilte
175175
// value can never be undefined because when it's undefined the button itself doesn't render/
176176
onClick={() => onClearButtonClick?.({ value: value ?? '' })}
177177
disabled={isDisabled}
178+
{...metaAttribute({ name: 'filter-chip-close-button' })}
178179
>
179180
<CloseIcon size="small" color="interactive.icon.gray.muted" />
180181
</StyledFilterCloseButton>

0 commit comments

Comments
 (0)