feat(spm): redesign react-native spm to add/update/deinit; drop from-scratch generator

Replace the ambiguous `init`/`--from-scratch` (with its silent
in-place→from-scratch fall-through that could rename a user's project to
.legacy) with four clear verbs:

  add      inject SPM into the existing .xcodeproj, in place (idempotent;
           fail-loud on a CocoaPods-integrated pbxproj). --deintegrate runs
           `pod deintegrate` + strips RN from the Podfile + removes the
           leftover empty Pods group.
  update   re-run the pipeline + refresh the injection.
  deinit   surgical inverse of add (reverse exactly what .spm-injected.json
           records → byte-identical revert; no prompt).
  scaffold unchanged.
  sync/codegen/download stay but are hidden from primary help.

Zero-arg `npx react-native spm` auto-resolves: injected→update; a fresh
CocoaPods project (safe-gate: stock Podfile + git-clean pbxproj/Podfile)→
add --deintegrate; else strict add.

- Delete the from-scratch xcodeproj generator + legacy-migration/Podfile-patch
  machinery and the now-dead whole-file-generation helpers in spm-pbxproj.js.
- Add surgical pbxproj removal primitives (removeObjectByUuid,
  removeArrayMembersByUuid, removeField, removeArrayStringValues,
  removeEmptyPodsGroup); injection now records its exact edits in
  .spm-injected.json so deinit can reverse them.
- Merge flags: --skip/force-download → --download <auto|skip|force>;
  --local-xcframework + --artifacts-dir → --artifacts <path>. Remove
  --skip-xcodeproj/--force-xcodeproj/--bundle-identifier/--entry-file and the
  --platform-name CLI shim.
- generate-spm-package now throws on artifact-slot failures (incl. missing
  ReactNativeHeaders) instead of a silent exitCode+return.
- Update CLI registration, __doc__/spm-scripts.md, and the spm test suite.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: chrfalch

packages/react-native/react-native.config.js

@@ -116,105 +116,53 @@ const spmCommand /*: Command */ = {
   name: 'spm [action]',
   description:
     'Set up or maintain Swift Package Manager support for the iOS/macOS app. ' +
-    'Actions: init, update, sync, clean, codegen, download, scaffold. ' +
-    'With no action: defaults to update.',
+    'Actions: add, update, deinit, scaffold. With no action: add (or update ' +
+    'if SPM is already set up).',
   options: [
     {
       name: '--version <string>',
       description:
         'React Native version (e.g. 0.80.0). Defaults to the version in node_modules/react-native/package.json.',
     },
-    {
-      name: '--localXcframework <path>',
-      description: 'Use a local React.xcframework instead of downloading.',
-    },
-    {
-      name: '--artifactsDir <path>',
-      description: 'Override the artifact cache directory.',
-    },
     {
       name: '--flavor <string>',
       description: 'Artifact flavor: debug or release.',
     },
     {
-      name: '--skipCodegen',
-      description: 'Skip react-native codegen step.',
-    },
-    {
-      name: '--skipDownload',
-      description: 'Skip automatic artifact download.',
-    },
-    {
-      name: '--forceDownload',
-      description: 'Clear cached artifacts and re-download from Maven.',
-    },
-    {
-      name: '--skipXcodeproj',
-      description: 'Skip .xcodeproj generation.',
-    },
-    {
-      name: '--forceXcodeproj',
-      description:
-        'Regenerate <App>.xcodeproj even when one already exists. ' +
-        'Clobbers Xcode-side edits (signing, capabilities, Build Phases).',
-    },
-    {
-      name: '--fromScratch',
-      description:
-        '[init] Generate a brand-new <App>.xcodeproj (renaming the existing ' +
-        'one to .legacy) instead of the default in-place injection into the ' +
-        'existing project.',
+      name: '--yes',
+      description: 'Skip the dirty-pbxproj confirmation prompt.',
     },
     {
       name: '--xcodeproj <path>',
       description:
-        '[init] Path to the existing .xcodeproj to inject SPM packages into ' +
+        '[add] Path to the .xcodeproj to inject SPM packages into ' +
         '(disambiguates when several exist).',
     },
-    {
-      name: '--bundleIdentifier <string>',
-      description: 'Override CFBundleIdentifier in the generated Info.plist.',
-    },
     {
       name: '--productName <string>',
-      description: 'Override PRODUCT_NAME in the generated Info.plist.',
-    },
-    {
-      name: '--entryFile <path>',
       description:
-        'JS entry file relative to app root (default: package.json "main" or index.js).',
+        '[add] App target to inject into (disambiguates when several exist).',
     },
     {
-      name: '--project',
+      name: '--deintegrate',
       description:
-        '[clean] Also remove Package.swift and <App>-SPM.xcodeproj/.',
+        '[add] Run `pod deintegrate` and strip React Native from the Podfile ' +
+        'before injecting (CocoaPods → SwiftPM migration).',
     },
     {
-      name: '--derivedData',
+      name: '--artifacts <path>',
       description:
-        "[clean] Also remove this app's DerivedData (~/Library/Developer/Xcode/DerivedData/<App>-SPM-*).",
+        '[advanced] Local artifact source: a .xcframework file (used directly, ' +
+        'no download) or a directory (cache dir to read/download into).',
     },
     {
-      name: '--cache',
+      name: '--download <string>',
       description:
-        '[clean] Also remove the cached xcframework slot for the current resolved version.',
+        '[advanced] Artifact download policy: auto (default), skip, or force.',
     },
     {
-      name: '--all',
-      description: '[clean] Shorthand for --project --derivedData --cache.',
-    },
-    {
-      name: '--yes',
-      description:
-        '[clean] Skip the confirmation prompt for destructive scopes.',
-    },
-    // Workaround for @react-native-community/cli: when any positional equals
-    // "init" (including our `spm init` action), the CLI naively appends
-    // `--platform-name <platform>` to argv. Accept and ignore it so commander
-    // does not reject the unknown option.
-    {
-      name: '--platform-name <string>',
-      description: '(ignored — CLI compatibility shim for `spm init`)',
+      name: '--skipCodegen',
+      description: '[advanced] Skip the react-native codegen step.',
     },
   ],
   func: async (argv, _config, args) => {
@@ -224,13 +172,11 @@ const spmCommand /*: Command */ = {
     }
     const stringOpts /*: Array<[string, string]> */ = [
       ['version', '--version'],
-      ['localXcframework', '--local-xcframework'],
-      ['artifactsDir', '--artifacts-dir'],
       ['flavor', '--flavor'],
-      ['bundleIdentifier', '--bundle-identifier'],
       ['productName', '--product-name'],
-      ['entryFile', '--entry-file'],
       ['xcodeproj', '--xcodeproj'],
+      ['artifacts', '--artifacts'],
+      ['download', '--download'],
     ];
     for (const [key, flag] of stringOpts) {
       if (args[key] != null) {
@@ -239,15 +185,7 @@ const spmCommand /*: Command */ = {
     }
     const boolOpts /*: Array<[string, string]> */ = [
       ['skipCodegen', '--skip-codegen'],
-      ['skipDownload', '--skip-download'],
-      ['forceDownload', '--force-download'],
-      ['skipXcodeproj', '--skip-xcodeproj'],
-      ['forceXcodeproj', '--force-xcodeproj'],
-      ['fromScratch', '--from-scratch'],
-      ['project', '--project'],
-      ['derivedData', '--derived-data'],
-      ['cache', '--cache'],
-      ['all', '--all'],
+      ['deintegrate', '--deintegrate'],
       ['yes', '--yes'],
     ];
     for (const [key, flag] of boolOpts) {