Annotate throwable methods in ColorPropConverter, log bad Android resource lookup (#57239)#57239
Closed
Abbondanzo wants to merge 1 commit into
Closed
Annotate throwable methods in ColorPropConverter, log bad Android resource lookup (#57239)#57239Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108777172. |
meta-cla
Bot
added
the
CLA Signed
…ource lookup (react#57239) Summary: Adds logcat logging when resource lookups fail if `resource_paths` is defined for a color prop, and annotates the `ColorProp` calls with the throwable class that they can raise Changelog: [Internal] Reviewed By: zeyap Differential Revision: D108777172
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D108777172
branch
from
b59af81 to
feb8f1e
Compare
|
This pull request has been merged in 8a3549a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds logcat logging when resource lookups fail if
resource_pathsis defined for a color prop, and annotates theColorPropcalls with the throwable class that they can raiseChangelog: [Internal]
Reviewed By: zeyap
Differential Revision: D108777172