fix: add back downloads specs

That was a sinatra disposition header issue, not chrome that was opening pdf extension. The header was not set because public folder was handled by rack static and file was returned to chrome without disposition header making chrome extension to intercept pdf request.

Author: route

spec/downloads_spec.rb

@@ -4,15 +4,8 @@
   let(:filename) { "attachment.pdf" }
   let(:save_path) { "/tmp/ferrum" }
 
-  def skip_browser_bug
-    # Also https://github.com/puppeteer/puppeteer/issues/10161
-    skip "https://bugs.chromium.org/p/chromium/issues/detail?id=1444729"
-  end
-
   describe "#files" do
     it "saves an attachment" do
-      skip_browser_bug
-
       page.downloads.set_behavior(save_path: save_path)
       page.go_to("/#{filename}")
       page.downloads.wait
@@ -50,8 +43,6 @@ def skip_browser_bug
   describe "#set_behavior" do
     context "with absolute path" do
       it "saves an attachment" do
-        skip_browser_bug
-
         page.downloads.set_behavior(save_path: save_path)
         page.go_to("/#{filename}")
         page.downloads.wait
@@ -62,18 +53,14 @@ def skip_browser_bug
       end
 
       it "saves no attachment when behavior is deny" do
-        skip_browser_bug
-
         page.downloads.set_behavior(save_path: save_path, behavior: :deny)
         page.downloads.wait { page.go_to("/#{filename}") }
 
         expect(File.exist?("#{save_path}/#{filename}")).to be false
       end
 
       it "saves an attachment on click" do
-        skip_browser_bug
-
-        page.downloads.set_behavior(save_path: save_path)
+        §        page.downloads.set_behavior(save_path: save_path)
         page.go_to("/attachment")
         page.downloads.wait { page.at_css("#download").click }
 

spec/support/application.rb

@@ -5,10 +5,12 @@
 module Ferrum
   class Application < Sinatra::Base
     configure { set :protection, except: :frame_options }
-    FERRUM_VIEWS  = "#{File.dirname(__FILE__)}/views".freeze
-    FERRUM_PUBLIC = "#{File.dirname(__FILE__)}/public".freeze
 
-    set :root, File.dirname(__FILE__)
+    FERRUM_APP = File.dirname(__FILE__)
+    FERRUM_VIEWS  = "#{FERRUM_APP}/views".freeze
+    FERRUM_PUBLIC = "#{FERRUM_APP}/public".freeze
+
+    set :root, FERRUM_APP
     set :static, true
     set :raise_errors, true
     set :show_exceptions, false
@@ -65,8 +67,9 @@ def authorized?(login, password)
     end
 
     get "/attachment.pdf" do
-      attachment("attachment.pdf")
-      send_file("attachment.pdf")
+      send_file File.join(FERRUM_APP, "static", "attachment.pdf"),
+                disposition: :attachment,
+                filename: "attachment.pdf"
     end
 
     get "/foo" do