Start line of code unit includes attributes

[mvorisek]

Q	A
php-code-coverage version	10.1.11
PHP version	8.3.0
Driver	Xdebug
PCOV version (if used)	n/a
Xdebug version (if used)	3.3.1
Installation Method	Composer
Usage Method	PHPUnit
PHPUnit version (if used)	10.5.9

repro code:

<?php

declare(strict_types=1);

namespace Atk4\Data\Persistence;

// dummy space to match the line numbers in the screenshot below
//

class GenericPlatform extends Platforms\AbstractPlatform
{
    private function createNotSupportedException(): \Exception
    {
        return DbalException::notSupported('SQL');
    }

    #[\Override]
    public function getName(): string
    {
        return 'atk4_data_generic';
    }

    #[\Override]
    protected function initializeDoctrineTypeMappings(): void {}
}

This is a feature request to improve the emitted coverage line of method to be the "line where the method name (or visibility) is declared".

In the example screen, I would coverage to be emitted on l18 and l24 (instead l17 and l23).

[sebastianbergmann]

Lines that only contain attribute declarations should be marked as not executable / coverable.

[SebastianSimon]

@sebastianbergmann
It seems that multiline attributes are still partially seen as executable:

#[MyAttribute([    // not executable
  MyEnum::CASE_A,  // executable, uncovered!
  MyEnum::CASE_B,  // executable, uncovered!
])]                // executable, uncovered!
class MyClass {}

Interestingly, classes that appear after MyEnum in the directory structure don’t have similar lines marked as executable. If I edit MyClass anywhere and run the coverage report again, suddenly the whole attribute is no longer marked as executable. It seems as if whether such lines are marked as executable depends on whether MyEnum was already “seen” by the coverage report (with the same cache left intact).

[mvorisek]

maybe fixed by #1149

[mvorisek]

maybe fixed by #1149

@sebastianbergmann please reopen, the #1149 is related, but it did not fix this issue.