Fix table_list_decoder

Previously it relied on dict value ordering (big no no)

Author: DynamicCake

src/glua.gleam

@@ -581,7 +581,14 @@ fn do_table(values: List(#(Value, Value)), lua: Lua) -> #(Value, Lua)
 pub fn table_list_decoder(
   inner decoder: decode.Decoder(a),
 ) -> decode.Decoder(List(a)) {
-  decode.dict(decode.int, decoder) |> decode.map(dict.values)
+  decode.dict(decode.int, decoder) |> decode.map(list_loop(_, [], 1))
+}
+
+fn list_loop(dict: dict.Dict(Int, a), acc: List(a), idx: Int) {
+  case dict.get(dict, idx) {
+    Ok(it) -> list_loop(dict, [it, ..acc], idx + 1)
+    Error(Nil) -> list.reverse(acc)
+  }
 }
 
 /// Encodes a Gleam function into a Lua function.

test/glua_test.gleam

@@ -44,21 +44,46 @@ pub fn get_table_test() {
 
 pub fn table_list_test() {
   let list = ["foo", "bar", "baz", "qux"]
-  glua.run(glua.new(), {
-    use val <- glua.then(glua.table_list(list |> list.map(glua.string)))
-    use decoded <- glua.then(glua.dereference(
-      val,
-      glua.table_list_decoder(decode.string),
-    ))
-    assert list == decoded
-    use decoded <- glua.then(glua.dereference(
-      val,
-      decode.dict(decode.int, decode.string),
-    ))
-    assert dict.to_list(decoded)
-      == [#(1, "foo"), #(2, "bar"), #(3, "baz"), #(4, "qux")]
-    glua.success(Nil)
-  })
+  let assert Ok(Nil) =
+    glua.run(glua.new(), {
+      use val <- glua.then(glua.table_list(list |> list.map(glua.string)))
+      use decoded <- glua.then(glua.dereference(
+        val,
+        glua.table_list_decoder(decode.string),
+      ))
+      assert list == decoded
+      use decoded <- glua.then(glua.dereference(
+        val,
+        decode.dict(decode.int, decode.string),
+      ))
+      assert dict.to_list(decoded)
+        == [#(1, "foo"), #(2, "bar"), #(3, "baz"), #(4, "qux")]
+      glua.success(Nil)
+    })
+}
+
+pub fn table_list_edge_test() {
+  let values =
+    [
+      #(-1, "qux"),
+      #(1, "foo"),
+      #(2, "bar"),
+      #(4, "baz"),
+      #(-123, "red herring"),
+    ]
+    |> list.map(pair.map_first(_, glua.int))
+    |> list.map(pair.map_second(_, glua.string))
+
+  let assert Ok(Nil) =
+    glua.run(glua.new(), {
+      use val <- glua.then(glua.table(values))
+      use decoded <- glua.then(glua.dereference(
+        val,
+        glua.table_list_decoder(decode.string),
+      ))
+      assert decoded == ["foo", "bar"]
+      glua.success(Nil)
+    })
 }
 
 pub fn sandbox_test() {