Draft jobs table: Show caution for older data

Author: marksvc

AGENTS.md

@@ -113,6 +113,10 @@ This repository contains three interconnected applications:
 
 - Pay attention to available types and type guards in src/SIL.XForge.Scripture/ClientApp/src/type-utils.ts.
 
+# Tests
+
+- If a unit test is more than 20 lines long, then place a line with "// SUT" before the line that causes the code being tested to be exercised.
+
 # Running commands
 
 - If you run frontend tests, run them in the `src/SIL.XForge.Scripture/ClientApp` directory with a command such as `npm run test:headless -- --watch=false --include '**/text.component.spec.ts' --include '**/settings.component.spec.ts'`

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.html

@@ -48,6 +48,13 @@
     </div>
   </div>
 
+  @if (shouldShowDurationComparisonCaution) {
+    <app-notice icon="calendar_month" type="warning">
+      Be careful about comparing Serval build outcomes and durations before 2025-12-18 with those after, because of
+      changes to the event grouping system.
+    </app-notice>
+  }
+
   @if (!isLoading) {
     @if (currentProjectFilter) {
       <app-notice icon="filter_alt" mode="fill-dark">

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.spec.ts

@@ -648,6 +648,35 @@ describe('DraftJobsComponent', () => {
       }));
     });
 
+    describe('shouldShowDurationComparisonCaution', () => {
+      it('should return false if no date range is set', fakeAsync(() => {
+        const env = new TestEnvironment({ hasEvents: false });
+        env.wait();
+        env.component['currentDateRange'] = undefined;
+
+        // SUT
+        expect(env.component.shouldShowDurationComparisonCaution).toBeFalse();
+      }));
+
+      it('should return true when the date range starts before the cutoff', fakeAsync(() => {
+        const env = new TestEnvironment({ hasEvents: false });
+        env.wait();
+        env.setDateRange(new Date('2025-12-01'), new Date('2026-01-20'));
+
+        // SUT
+        expect(env.component.shouldShowDurationComparisonCaution).toBeTrue();
+      }));
+
+      it('should return false when the date range starts after the cutoff', fakeAsync(() => {
+        const env = new TestEnvironment({ hasEvents: false });
+        env.wait();
+        env.setDateRange(new Date('2026-01-20'), new Date('2026-02-20'));
+
+        // SUT
+        expect(env.component.shouldShowDurationComparisonCaution).toBeFalse();
+      }));
+    });
+
     describe('formatDurationInHours', () => {
       it('should format duration in decimal hours', fakeAsync(() => {
         const env = new TestEnvironment({ hasEvents: false });

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.ts

@@ -136,6 +136,10 @@ const DRAFTING_EVENTS = [
   ]
 })
 export class DraftJobsComponent extends DataLoadingComponent implements OnInit {
+  /** Time when draftGenerationRequestId began to be used, which was in SFv5.46.1 shortly before
+   * 2025-12-18T17:48:57Z. */
+  private static readonly requestIdIntroductionDate: Date = new Date('2025-12-18T17:48:57Z');
+
   columnsToDisplay: string[] = [
     'status',
     'projectId',
@@ -210,6 +214,12 @@ export class DraftJobsComponent extends DataLoadingComponent implements OnInit {
     return this.formatDurationInHours(this.maxDuration);
   }
 
+  /** Whether to show a caution notice about comparing older durations. */
+  get shouldShowDurationComparisonCaution(): boolean {
+    if (this.currentDateRange == null) return false;
+    return this.currentDateRange.start < DraftJobsComponent.requestIdIntroductionDate;
+  }
+
   ngOnInit(): void {
     if (
       !this.columnsToDisplay.includes('buildDetails') &&