fix(processing): address audit findings across branch

- preprocessing.ts: use undefined (not null) for failed subscription
  fetch so getUserUsageLimit does a fresh lookup instead of silently
  falling back to free-tier limits
- deployed/route.ts: log warning on loadDeployedWorkflowState failure
  instead of silently swallowing the error
- schedule-execution.ts: remove dead successLog parameter and all
  call-site arguments left over from logger.debug cleanup
- mcp/middleware.ts: drop unused error binding in empty catch
- audit/log.ts, wand.ts: promote logger.debug to logger.warn in catch
  blocks where these are the only failure signal

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/app/api/workflows/[id]/deployed/route.ts

@@ -48,7 +48,8 @@ export async function GET(request: NextRequest, { params }: { params: Promise<{
         parallels: data.parallels,
         variables: data.variables,
       }
-    } catch {
+    } catch (error) {
+      logger.warn(`[${requestId}] Failed to load deployed state for workflow ${id}`, { error })
       deployedState = null
     }
 

apps/sim/background/schedule-execution.ts

@@ -40,8 +40,7 @@ async function applyScheduleUpdate(
   scheduleId: string,
   updates: WorkflowScheduleUpdate,
   requestId: string,
-  context: string,
-  successLog?: string
+  context: string
 ) {
   try {
     await db.update(workflowSchedule).set(updates).where(eq(workflowSchedule.id, scheduleId))
@@ -349,8 +348,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
               status: 'disabled',
             },
             requestId,
-            `Failed to disable schedule ${payload.scheduleId} after authentication error`,
-            `Disabled schedule ${payload.scheduleId} due to authentication failure (401)`
+            `Failed to disable schedule ${payload.scheduleId} after authentication error`
           )
           return
         }
@@ -368,8 +366,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
               status: 'disabled',
             },
             requestId,
-            `Failed to disable schedule ${payload.scheduleId} after authorization error`,
-            `Disabled schedule ${payload.scheduleId} due to authorization failure (403)`
+            `Failed to disable schedule ${payload.scheduleId} after authorization error`
           )
           return
         }
@@ -384,8 +381,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
               status: 'disabled',
             },
             requestId,
-            `Failed to disable schedule ${payload.scheduleId} after missing workflow`,
-            `Disabled schedule ${payload.scheduleId} because the workflow no longer exists`
+            `Failed to disable schedule ${payload.scheduleId} after missing workflow`
           )
           return
         }
@@ -402,8 +398,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
               nextRunAt: nextRetryAt,
             },
             requestId,
-            `Error updating schedule ${payload.scheduleId} for rate limit`,
-            `Updated next retry time for schedule ${payload.scheduleId} due to rate limit`
+            `Error updating schedule ${payload.scheduleId} for rate limit`
           )
           return
         }
@@ -419,8 +414,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
                 nextRunAt,
               },
               requestId,
-              `Error updating schedule ${payload.scheduleId} after usage limit check`,
-              `Scheduled next run for ${payload.scheduleId} after usage limit`
+              `Error updating schedule ${payload.scheduleId} after usage limit check`
             )
           }
           return
@@ -448,8 +442,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
               status: shouldDisable ? 'disabled' : 'active',
             },
             requestId,
-            `Error updating schedule ${payload.scheduleId} after preprocessing failure`,
-            `Updated schedule ${payload.scheduleId} after preprocessing failure`
+            `Error updating schedule ${payload.scheduleId} after preprocessing failure`
           )
           return
         }
@@ -501,8 +494,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
             lastQueuedAt: null,
           },
           requestId,
-          `Error updating schedule ${payload.scheduleId} after success`,
-          `Updated next run time for workflow ${payload.workflowId} to ${nextRunAt.toISOString()}`
+          `Error updating schedule ${payload.scheduleId} after success`
         )
         return
       }
@@ -529,8 +521,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
           status: shouldDisable ? 'disabled' : 'active',
         },
         requestId,
-        `Error updating schedule ${payload.scheduleId} after failure`,
-        `Updated schedule ${payload.scheduleId} after failure`
+        `Error updating schedule ${payload.scheduleId} after failure`
       )
     } catch (error: unknown) {
       const errorMessage = error instanceof Error ? error.message : String(error)
@@ -548,8 +539,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
             nextRunAt: nextRetryAt,
           },
           requestId,
-          `Error updating schedule ${payload.scheduleId} for service overload`,
-          `Updated schedule ${payload.scheduleId} retry time due to service overload`
+          `Error updating schedule ${payload.scheduleId} for service overload`
         )
         return
       }
@@ -576,8 +566,7 @@ export async function executeScheduleJob(payload: ScheduleExecutionPayload) {
           status: shouldDisable ? 'disabled' : 'active',
         },
         requestId,
-        `Error updating schedule ${payload.scheduleId} after execution error`,
-        `Updated schedule ${payload.scheduleId} after execution error`
+        `Error updating schedule ${payload.scheduleId} after execution error`
       )
     }
   } catch (error: unknown) {

apps/sim/lib/audit/log.ts

@@ -215,7 +215,7 @@ async function insertAuditLog(params: AuditLogParams): Promise<void> {
       actorName = row?.name ?? undefined
       actorEmail = row?.email ?? undefined
     } catch (error) {
-      logger.debug('Failed to resolve actor info', { error, actorId: params.actorId })
+      logger.warn('Failed to resolve actor info', { error, actorId: params.actorId })
     }
   }
 

apps/sim/lib/execution/preprocessing.ts

@@ -265,7 +265,7 @@ export async function preprocessExecution(
   }
 
   // ========== STEP 4: Get Subscription ==========
-  let userSubscription: SubscriptionInfo = null
+  let userSubscription: SubscriptionInfo | undefined
   try {
     userSubscription = await getHighestPrioritySubscription(actorUserId)
   } catch (error) {
@@ -350,7 +350,7 @@ export async function preprocessExecution(
       const rateLimiter = new RateLimiter()
       rateLimitInfo = await rateLimiter.checkRateLimitWithSubscription(
         actorUserId,
-        userSubscription,
+        userSubscription ?? null,
         triggerType,
         false // not async
       )
@@ -419,7 +419,7 @@ export async function preprocessExecution(
     success: true,
     actorUserId,
     workflowRecord,
-    userSubscription,
+    userSubscription: userSubscription ?? null,
     rateLimitInfo,
     executionTimeout: {
       sync: getExecutionTimeout(plan, 'sync'),

apps/sim/lib/mcp/middleware.ts

@@ -71,7 +71,7 @@ async function validateMcpAuth(
           workspaceId = body.workspaceId
           ;(request as any)._parsedBody = body
         }
-      } catch (error) {}
+      } catch {}
     }
 
     if (!workspaceId) {

apps/sim/lib/table/llm/wand.ts

@@ -54,7 +54,7 @@ export async function enrichTableSchema(
     const label = table.name ? `${table.name} (${tableId})` : tableId
     return `Table schema for ${label}:\n${columnLines}\nBuilt-in columns: createdAt, updatedAt`
   } catch (error) {
-    logger.debug('Failed to fetch table schema', { tableId, error })
+    logger.warn('Failed to fetch table schema', { tableId, error })
     return null
   }
 }