Skip to content

Commit 91a9c20

Browse files
authored
fix(deps): build isolated-vm on install via root trustedDependencies (#5935)
.npmrc set ignore-scripts=true globally, which overrode Bun's trustedDependencies allowlist and blocked every lifecycle script — including the repo's own root scripts. isolated-vm therefore shipped unbuilt and each contributor had to npm rebuild it by hand. The .npmrc line landed in the May 2025 Bun migration, seven months before isolated-vm was introduced. Two later commits added isolated-vm to trustedDependencies (root, then apps/sim) and both were silently inert. - delete .npmrc; lifecycle policy now lives solely in root trustedDependencies - add isolated-vm to root trustedDependencies - drop the workspace-level trustedDependencies from apps/sim (Bun only reads the root list, so it never had any effect) - drop the .npmrc entry from CODEOWNERS Naming any package in trustedDependencies replaces Bun's curated default-trust list, so only isolated-vm and sharp may run install scripts. Docker is unaffected — all three Dockerfiles pass --ignore-scripts explicitly and rebuild isolated-vm against the Node ABI by hand.
1 parent 5a8d219 commit 91a9c20

5 files changed

Lines changed: 2 additions & 11 deletions

File tree

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,3 @@ package.json @simstudioai/deps
3737
bun.lock @simstudioai/deps
3838
**/bun.lock @simstudioai/deps
3939
bunfig.toml @simstudioai/deps
40-
.npmrc @simstudioai/deps

.npmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

apps/sim/package.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -257,13 +257,6 @@
257257
"vite-tsconfig-paths": "^5.1.4",
258258
"vitest": "^4.1.0"
259259
},
260-
"trustedDependencies": [
261-
"canvas",
262-
"better-sqlite3",
263-
"ffmpeg-static",
264-
"isolated-vm",
265-
"sharp"
266-
],
267260
"overrides": {
268261
"next": "16.2.11",
269262
"@next/env": "16.2.11",

bun.lock

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
]
9090
},
9191
"trustedDependencies": [
92+
"isolated-vm",
9293
"sharp"
9394
],
9495
"dependencies": {

0 commit comments

Comments
 (0)