fix(secrets): simplify copilot mounting flow

Author: icecrasher321

apps/docs/content/docs/en/platform/credentials.mdx

@@ -79,7 +79,7 @@ Masking is activated only when Sim successfully resolves a value from **Settings
 
 Copilot's Function and code-execution tools receive a saved secret only when their code explicitly contains a valid `{{KEY}}` reference. Direct `environmentVariables.KEY` access, shell `$KEY`, dynamic names, literals, and configured-but-unused secrets do not mount a value. Code execution requires workspace write access, and the caller must also be allowed to view the raw value: your own Personal secrets, any secret for which you are a Credential Admin, and Workspace secrets when you are a workspace admin. Credential Members can continue using shared secrets through normal workflow and tool resolution, but cannot mount their plaintext into arbitrary Copilot code.
 
-Interactive code calls require **Allow** for that individual call, even if the tool was previously allowed for the chat or account. Headless surfaces use their saved **Secret access** setting:
+Headless surfaces use their saved **Secret access** setting:
 
 - **Sim Chat block** — under **Show additional fields**
 - **Scheduled Tasks** — in the task modal

apps/sim/app/api/copilot/tool-permission/route.test.ts

@@ -1,6 +1,5 @@
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
-import { isRecordLike } from '@sim/utils/object'
 import { type NextRequest, NextResponse } from 'next/server'
 import { copilotToolPermissionContract } from '@/lib/api/contracts/copilot'
 import { parseRequest, validationErrorResponse } from '@/lib/api/server'
@@ -22,14 +21,12 @@ import {
 } from '@/lib/copilot/persistence/tool-permission/auto-allow'
 import {
   authenticateCopilotRequestSessionOnly,
-  createBadRequestResponse,
   createInternalServerErrorResponse,
   createNotFoundResponse,
   createRequestTracker,
   createUnauthorizedResponse,
 } from '@/lib/copilot/request/http'
 import { withIncomingGoSpan } from '@/lib/copilot/request/otel'
-import { getToolSecretMountNames } from '@/lib/copilot/tools/secret-mount'
 import { isCopilotToolPermissionsEnabled } from '@/lib/core/config/env-flags'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 
@@ -41,10 +38,6 @@ interface DecisionResult {
   applied: boolean
 }
 
-interface RejectedDecision {
-  rejection: 'permission-feature-disabled' | 'persistent-secret-permission'
-}
-
 /**
  * Records one prompt answer and wakes the orchestrator waiting on it.
  *
@@ -56,7 +49,7 @@ async function applyDecision(
   toolCallId: string,
   decision: ToolPermissionDecision,
   userId: string
-): Promise<DecisionResult | RejectedDecision | null> {
+): Promise<DecisionResult | null> {
   const existing = await getAsyncToolCall(toolCallId).catch((err) => {
     logger.warn('Failed to fetch async tool call', { toolCallId, error: getErrorMessage(err) })
     return null
@@ -72,19 +65,6 @@ async function applyDecision(
   })
   if (!run || run.userId !== userId) return null
 
-  const args = isRecordLike(existing.args) ? existing.args : undefined
-  const mountsSecrets = getToolSecretMountNames(existing.toolName, args).length > 0
-  if (!isCopilotToolPermissionsEnabled && !mountsSecrets) {
-    return { rejection: 'permission-feature-disabled' }
-  }
-  if (
-    mountsSecrets &&
-    (decision === TOOL_PERMISSION_DECISION.allow_chat ||
-      decision === TOOL_PERMISSION_DECISION.always_allow)
-  ) {
-    return { rejection: 'persistent-secret-permission' }
-  }
-
   const claimed = await recordToolPermissionDecision(toolCallId, decision)
   if (!claimed) {
     // Someone already answered. Report their decision rather than pretending
@@ -137,6 +117,13 @@ export const POST = withRouteHandler((req: NextRequest) => {
     { [TraceAttr.RequestId]: tracker.requestId },
     async (span) => {
       try {
+        // Nothing can legitimately be awaiting a decision while the feature is
+        // off, so close the endpoint rather than letting it write decisions
+        // onto rows no orchestrator is waiting on.
+        if (!isCopilotToolPermissionsEnabled) {
+          return createNotFoundResponse('Tool permissions are not enabled')
+        }
+
         const { userId: authenticatedUserId, isAuthenticated } =
           await authenticateCopilotRequestSessionOnly()
 
@@ -167,12 +154,6 @@ export const POST = withRouteHandler((req: NextRequest) => {
         const results: DecisionResult[] = []
         for (const { toolCallId, decision } of decisions) {
           const result = await applyDecision(toolCallId, decision, authenticatedUserId)
-          if (result && 'rejection' in result) {
-            if (result.rejection === 'permission-feature-disabled') {
-              return createNotFoundResponse('Tool permissions are not enabled')
-            }
-            return createBadRequestResponse('Secret-bearing code calls can only be allowed once')
-          }
           if (result) results.push(result)
         }
 

apps/sim/app/api/copilot/tool-permission/route.ts

@@ -4,7 +4,6 @@ import { useCallback, useEffect, useState } from 'react'
 import {
   ChevronDown,
   Chip,
-  ChipTag,
   DropdownMenu,
   DropdownMenuContent,
   DropdownMenuItem,
@@ -17,7 +16,6 @@ import { createLogger } from '@sim/logger'
 import { useQueryClient } from '@tanstack/react-query'
 import { requestJson } from '@/lib/api/client/request'
 import { copilotToolPermissionContract } from '@/lib/api/contracts/copilot'
-import { getToolSecretMountNames } from '@/lib/copilot/tools/secret-mount'
 import { generalSettingsKeys } from '@/hooks/queries/general-settings'
 import { useToolPermissionStore } from '@/stores/tool-permission/store'
 
@@ -130,8 +128,6 @@ export function ToolPermissionCard({
   )
 
   const preview = argsPreview(params)
-  const mountedSecretNames = getToolSecretMountNames(toolName, params)
-  const mountsSecrets = mountedSecretNames.length > 0
   const busy = submitting !== null || isSubmitted
 
   if (expired) {
@@ -173,39 +169,26 @@ export function ToolPermissionCard({
         <Chip variant='primary' disabled={busy} onClick={() => void submit('allow', [toolCallId])}>
           Allow
         </Chip>
-        {!mountsSecrets && (
-          <DropdownMenu>
-            <DropdownMenuTrigger asChild>
-              <Chip variant='border' rightIcon={ChevronDown} disabled={busy}>
-                Don't ask again
-              </Chip>
-            </DropdownMenuTrigger>
-            <DropdownMenuContent align='start'>
-              <DropdownMenuItem onSelect={() => void submit('allow_chat', [toolCallId])}>
-                For this chat
-              </DropdownMenuItem>
-              <DropdownMenuItem onSelect={() => void submit('always_allow', [toolCallId])}>
-                For every chat
-              </DropdownMenuItem>
-            </DropdownMenuContent>
-          </DropdownMenu>
-        )}
+        <DropdownMenu>
+          <DropdownMenuTrigger asChild>
+            <Chip variant='border' rightIcon={ChevronDown} disabled={busy}>
+              Don't ask again
+            </Chip>
+          </DropdownMenuTrigger>
+          <DropdownMenuContent align='start'>
+            <DropdownMenuItem onSelect={() => void submit('allow_chat', [toolCallId])}>
+              For this chat
+            </DropdownMenuItem>
+            <DropdownMenuItem onSelect={() => void submit('always_allow', [toolCallId])}>
+              For every chat
+            </DropdownMenuItem>
+          </DropdownMenuContent>
+        </DropdownMenu>
         <Chip disabled={busy} onClick={() => void submit('skip', [toolCallId])}>
           Skip
         </Chip>
       </div>
 
-      {mountsSecrets && (
-        <div className='flex flex-wrap items-center gap-1 pl-[22px]'>
-          <span className='mr-1 text-[var(--text-tertiary)] text-xs'>Secrets</span>
-          {mountedSecretNames.map((name) => (
-            <ChipTag key={name} variant='mono'>
-              {`{{${name}}}`}
-            </ChipTag>
-          ))}
-        </div>
-      )}
-
       {showBulkActions && (
         <div className='flex flex-wrap items-center pl-[22px]'>
           <span className='mr-1 text-[var(--text-tertiary)] text-xs'>

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/tool-permission-card.tsx

@@ -2,12 +2,7 @@
  * @vitest-environment node
  */
 import { describe, expect, it } from 'vitest'
-import { FunctionExecute, Read, RunCode } from '@/lib/copilot/generated/tool-catalog-v1'
-import {
-  extractCodeSecretNames,
-  getToolSecretMountNames,
-  toolHasSecretMountCapability,
-} from '@/lib/copilot/tools/secret-mount'
+import { extractCodeSecretNames } from '@/executor/utils/code-secret-references'
 
 describe('Copilot code secret declarations', () => {
   it.each(['javascript', 'python'])(
@@ -39,12 +34,4 @@ describe('Copilot code secret declarations', () => {
       )
     ).toEqual([])
   })
-
-  it('uses the generated capability as the sole tool classifier', () => {
-    expect(toolHasSecretMountCapability(FunctionExecute.id)).toBe(true)
-    expect(toolHasSecretMountCapability(RunCode.id)).toBe(true)
-    expect(toolHasSecretMountCapability(Read.id)).toBe(false)
-    expect(getToolSecretMountNames(Read.id, { code: 'return {{SECRET}}' })).toEqual([])
-    expect(getToolSecretMountNames(RunCode.id, { code: 'return {{SECRET}}' })).toEqual(['SECRET'])
-  })
 })