feat(tables): stable column ids for metadata-only rename by TheodoreSpeaks · Pull Request #4898 · simstudioai/sim

TheodoreSpeaks · 2026-06-06T18:09:48Z

Summary

Every table column gets a stable id; row data, metadata (widths/order/pins), workflow-group refs, and filter/sort key by id instead of by name
Column rename is metadata-only (no per-row JSONB rewrite); column delete is fire-and-forget (schema commits immediately, row storage reclaimed in the background)
First-party grid/API/hooks go id-native via a single getColumnId chokepoint; public v1 API + mothership tool + CSV translate name↔id at the boundary
Not tied to a feature flag — ships on deploy. Migration 0227_backfill_column_ids stamps id = name onto existing columns (metadata-only, idempotent); the legacy row-rewrite rename / sync-strip delete paths are removed

Type of Change

New feature (non-breaking)

Testing

Tested manually: rename keeps cell values with no row rewrite
Verified the backfill migration against a local DB (idempotent: UPDATE 101, re-run UPDATE 0)
bun run lint:check and bun run check:api-validation:strict pass
283 table / contract / hook unit tests pass (incl. new column-keys tests)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-06-06T18:09:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jun 9, 2026 6:08am

cursor · 2026-06-06T18:09:58Z

PR Summary

High Risk
This changes the core table data model and touches v1 APIs, imports, workflow execution, and a large grid surface area; incorrect id/name translation could corrupt reads/writes or break external integrations.

Overview
Introduces stable column ids as the storage key for row JSONB, table metadata (widths, order, pins), workflow-group deps/mappings, and find/filter/sort—while display names stay what users see and what CSV/v1/copilot callers use.

A new column-keys layer (getColumnId, rowDataNameToId / rowDataIdToName, withGeneratedColumnIds, etc.) centralizes translation. Renames are metadata-only (schema label + optimistic cache); hooks no longer rewrite row-data keys on rename. Import/export read/write id-keyed rows but expose name-keyed CSV/JSON; auto-created import columns get pre-assigned ids. normalizeColumn now keeps id so API clients don’t drop it.

The workspace grid is id-native end-to-end (column.key for cells, drag/pin/order/undo, workflow sidebars store deps by id). Public v1 rows APIs and the copilot table tool translate at the boundary. Workflow column execution builds name-keyed workflow input from id-keyed row data. Contracts add optional column id and document find matches by column id.

^{Reviewed by Cursor Bugbot for commit d91ef6c. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-06-06T18:15:32Z

Greptile Summary

This PR replaces name-keyed row storage with stable col_<uuid> column ids across the table subsystem, making column rename a metadata-only operation and fire-and-forgetting row-data cleanup on column delete.

Storage layer: column-keys.ts introduces getColumnId / generateColumnId / columnMatchesRef as the single chokepoint; every column-creation path (addTableColumn, addWorkflowGroup, addWorkflowGroupOutput, createTable) now stamps a stable id unconditionally.
Boundary translation: public v1 API, mothership tool, and CSV import/export translate column name ↔ id at the edge via buildIdByName / buildNameById / rowDataNameToId / rowDataIdToName; internal grid paths are id-native.
Migration 0229_backfill_column_ids: idempotent single-UPDATE stamps id = name on legacy columns (rows were already keyed by name, so no row rewrites needed).

Confidence Score: 5/5

Safe to merge — the stable-id system is consistent across all column-creation, storage, and translation paths, and the backfill migration is idempotent.

All column-creation paths unconditionally assign stable ids; boundary translation (name↔id) is applied consistently at the v1 API, mothership tool, and CSV edges; the migration correctly grandfathers legacy rows by setting id=name; assertValidSchema guards every schema write. The two deleteColumn/deleteColumns spread-pattern notes are a pre-existing condition that assertValidSchema already prevents from corrupting the DB — they improve error UX but are not correctness blockers.

apps/sim/lib/table/service.ts — the two deleteColumn/deleteColumns spread-pattern suggestions are worth applying to avoid opaque error messages when the last workflow-group output column is deleted.

Important Files Changed

Filename	Overview
apps/sim/lib/table/column-keys.ts	New module — the single chokepoint for id/name translation. All helpers (getColumnId, generateColumnId, columnMatchesRef, buildIdByName, buildNameById, row/filter/sort translators) are well-implemented and correctly documented.
apps/sim/lib/table/service.ts	All column-creation paths (addTableColumn, addWorkflowGroup, addWorkflowGroupOutput, createTable) unconditionally assign stable ids; renameColumn is now metadata-only; deleteColumn/deleteColumns fire-and-forget row-data cleanup; upsert error message now surfaces display name instead of internal id.
packages/db/migrations/0229_backfill_column_ids.sql	Idempotent single-UPDATE sets id=name for legacy columns; correctly skips columns that already carry an id; does not touch metadata (safe since id=name for legacy columns keeps existing metadata keys valid).
apps/sim/app/api/v1/tables/[tableId]/rows/upsert/route.ts	Correctly translates incoming name-keyed row data to id-keyed before calling upsertRow; conflictTarget is left as-is (service resolves it by id-or-name); response data translated back to names.
apps/sim/lib/table/workflow-columns.ts	validateSchema updated to key columnsById by getColumnId; assertValidSchema correctly catches group-references-missing-column invariant violations before any schema write.
apps/sim/lib/table/validation.ts	All validation helpers (coerceRowValues, checkUniqueConstraintsDb, checkBatchUniqueConstraintsDb) updated to use getColumnId for JSONB key lookups; NAME_PATTERN guard on raw-SQL interpolation paths is preserved.
apps/sim/lib/table/tests/column-keys.test.ts	New test file covering getColumnId fallback, generateColumnId format, columnMatchesRef (id-exact + name-ci), buildIdByName/buildNameById, row/filter/sort translators, and withGeneratedColumnIds; good coverage of the new chokepoint.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["v1 API / Mothership / CSV\n(column names on the wire)"] -->|rowDataNameToId\nfilterNamesToIds\nsortNamesToIds| B["Service Layer\n(row data keyed by col_id)"]
    B -->|rowDataIdToName\nbuildNameById| A
    B --> C["user_table_rows.data\nJSONB keyed by col_id"]
    B --> D["user_table_definitions.schema\ncolumns[].id = col_uuid"]
    B --> E["user_table_definitions.metadata\ncolumnOrder / widths / pinned\n(all keyed by col_id)"]
    F["Internal Grid / Hooks\n(id-native via getColumnId)"] -->|direct id keys| B
    G["Migration 0229\nid = name for legacy cols\nidempotent"] --> D
    subgraph col_keys["column-keys.ts chokepoint"]
        H["getColumnId(col)\ncol.id ?? col.name"]
        I["generateColumnId()\ncol_UUID"]
        J["columnMatchesRef(col, ref)\nid-exact OR name-ci"]
    end
    B --> col_keys

_{Reviews (10): Last reviewed commit: "fix(tables): translate id→name in CSV/JS..." | Re-trigger Greptile}

…me in upsert error, un-gate group output ids

TheodoreSpeaks · 2026-06-06T18:32:55Z

@greptile review

…use on re-add

TheodoreSpeaks · 2026-06-06T19:10:23Z

@greptile review

…on-check plumbing

TheodoreSpeaks · 2026-06-06T20:50:16Z

@greptile review

…stic delete cache

TheodoreSpeaks · 2026-06-08T17:10:11Z

@greptile review

…rename-column # Conflicts: # packages/db/migrations/meta/0227_snapshot.json # packages/db/migrations/meta/_journal.json

TheodoreSpeaks · 2026-06-08T19:11:04Z

@greptile review

…ips; biome-format 0228 snapshot

TheodoreSpeaks · 2026-06-09T00:06:31Z

@greptile review

…rename-column # Conflicts: # packages/db/migrations/meta/0228_snapshot.json # packages/db/migrations/meta/_journal.json

TheodoreSpeaks · 2026-06-09T05:26:50Z

@greptile review

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 98c883c. Configure here.}

…olumn ids)

TheodoreSpeaks · 2026-06-09T05:56:47Z

@greptile review

…ion test)

TheodoreSpeaks · 2026-06-09T06:08:45Z

@greptile review

TheodoreSpeaks · 2026-06-09T06:26:05Z

@greptile review

feat(tables): stable column ids for metadata-only rename

77abb11

cursor Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread apps/sim/lib/table/service.ts

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/data-row.tsx

vercel Bot deployed to Preview June 6, 2026 18:13 View deployment

greptile-apps Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread apps/sim/lib/table/service.ts

Comment thread apps/sim/lib/table/service.ts

fix(tables): address review — id-key exec clears + waiting labels, na…

c38d598

…me in upsert error, un-gate group output ids

vercel Bot temporarily deployed to Preview June 6, 2026 18:31 Inactive

cursor Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

fix(tables): id-correct column undo (rename/create/delete) with id re…

07597cc

…use on re-add

vercel Bot temporarily deployed to Preview June 6, 2026 19:09 Inactive

refactor(tables): mint column ids via generateId (uuid), drop collisi…

4dbcbcf

…on-check plumbing

vercel Bot temporarily deployed to Preview June 6, 2026 20:50 Inactive

cursor Bot reviewed Jun 6, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/tables.ts

fix(tables): match column id or name when removing column from optimi…

62c86c5

…stic delete cache

vercel Bot temporarily deployed to Preview June 8, 2026 17:09 Inactive

cursor Bot reviewed Jun 8, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/tables.ts

Merge remote-tracking branch 'origin/staging' into improvement/table-…

93bfba8

…rename-column # Conflicts: # packages/db/migrations/meta/0227_snapshot.json # packages/db/migrations/meta/_journal.json

vercel Bot deployed to Preview June 8, 2026 19:14 View deployment

fix(tables): resolve column storage id once for delete optimistic str…

40b94fe

…ips; biome-format 0228 snapshot

vercel Bot deployed to Preview June 9, 2026 00:09 View deployment

Merge remote-tracking branch 'origin/staging' into improvement/table-…

98c883c

…rename-column # Conflicts: # packages/db/migrations/meta/0228_snapshot.json # packages/db/migrations/meta/_journal.json

cursor Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread apps/sim/lib/table/service.ts

vercel Bot deployed to Preview June 9, 2026 05:30 View deployment

fix(tables): make in-grid find id-native (scan/return JSONB keys as c…

cfb1da5

…olumn ids)

vercel Bot temporarily deployed to Preview June 9, 2026 05:56 Inactive

fix(tables): translate id→name in CSV/JSON export read path (+regress…

d91ef6c

…ion test)

vercel Bot temporarily deployed to Preview June 9, 2026 06:08 Inactive

TheodoreSpeaks merged commit f7811f8 into staging Jun 9, 2026
14 checks passed

TheodoreSpeaks deleted the improvement/table-rename-column branch June 9, 2026 06:33

waleedlatif1 mentioned this pull request Jun 9, 2026

v0.7.0: vibes improvement, new UI, new tools, chat-first, mothership updates #4922

Open

TheodoreSpeaks mentioned this pull request Jun 9, 2026

fix(tables): key filter UI by stable column id; show column name in delete confirm #4930

Merged

6 tasks

Conversation

TheodoreSpeaks commented Jun 6, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jun 6, 2026

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jun 6, 2026

Uh oh!

TheodoreSpeaks commented Jun 6, 2026

Uh oh!

Uh oh!

TheodoreSpeaks commented Jun 8, 2026

Uh oh!

Uh oh!

TheodoreSpeaks commented Jun 8, 2026

Uh oh!

TheodoreSpeaks commented Jun 9, 2026

Uh oh!

TheodoreSpeaks commented Jun 9, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheodoreSpeaks commented Jun 9, 2026

Uh oh!

TheodoreSpeaks commented Jun 9, 2026

Uh oh!

TheodoreSpeaks commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jun 6, 2026 •

edited

Loading

cursor Bot commented Jun 6, 2026 •

edited

Loading

greptile-apps Bot commented Jun 6, 2026 •

edited

Loading