Move build tool tests to scip-java (#920)

Author: jupblb

CONTRIBUTING.md

@@ -182,6 +182,15 @@ lazy val cli = project
     // sbt invokes it directly (e.g. from the scip-kotlinc snapshots
     // task) so it cannot kill the surrounding sbt process.
     Compile / run / fork := true,
+    Test / fork := true,
+    // Our CI set up is a couple of measly vCPUs so parallelising tests there makes
+    // everything worse.
+    Test / testForkedParallel := !sys.env.contains("CI"),
+    // The SCIP build tool drives javac in-process; on JDK 17+ this requires
+    // opening the JDK-internal javac packages.
+    Test / javaOptions ++= javacModuleOptions.map(_.stripPrefix("-J")),
+    // Pin the JDK version embedded in stdlib SCIP symbols so output is stable.
+    Test / javaOptions += "-Dscip.jdk.version=11",
     libraryDependencies ++=
       List(
         "com.github.ajalt.clikt" % "clikt-jvm" % V.clikt,
@@ -195,6 +204,13 @@ lazy val cli = project
         "org.jetbrains.kotlin" % "kotlin-scripting-dependencies-maven" %
           V.kotlinVersion
       ),
+    libraryDependencies ++=
+      Seq(
+        "org.jetbrains.kotlin" % "kotlin-test" % V.kotlinVersion % Test,
+        "org.jetbrains.kotlin" % "kotlin-test-junit5" % V.kotlinVersion % Test,
+        "com.github.sbt.junit" % "jupiter-interface" %
+          JupiterKeys.jupiterVersion.value % Test
+      ),
     (Compile / resourceGenerators) +=
       Def
         .task {
@@ -450,32 +466,6 @@ def javacModuleOptions = List(
   "-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED"
 )
 
-lazy val buildTools = project
-  .in(file("tests/buildTools"))
-  .enablePlugins(KotlinPlugin)
-  .settings(
-    publish / skip := true,
-    kotlinVersion := V.kotlinVersion,
-    kotlincJvmTarget := "11",
-    Test / fork := true,
-    // Our CI set up is a couple of measly vCPUs so parallelising tests there makes
-    // everything worse
-    Test / testForkedParallel := !sys.env.contains("CI"),
-    // The SCIP build tool drives javac in-process; on JDK 17+ this requires
-    // opening the JDK-internal javac packages.
-    Test / javaOptions ++= javacModuleOptions.map(_.stripPrefix("-J")),
-    // Pin the JDK version embedded in stdlib SCIP symbols so output is stable.
-    Test / javaOptions += "-Dscip.jdk.version=11",
-    libraryDependencies ++=
-      Seq(
-        "org.jetbrains.kotlin" % "kotlin-test" % V.kotlinVersion % Test,
-        "org.jetbrains.kotlin" % "kotlin-test-junit5" % V.kotlinVersion % Test,
-        "com.github.sbt.junit" % "jupiter-interface" %
-          JupiterKeys.jupiterVersion.value % Test
-      )
-  )
-  .dependsOn(cli)
-
 lazy val snapshots = project
   .in(file("tests/snapshots"))
   .settings(

build.sbt

@@ -53,25 +53,26 @@
             cd ${./.}
             # Exclude minimized fixtures and generated SCIP snapshot goldens
             # (coupled to exact line/column annotations), the standalone example
-            # projects, and the buildTools test fixtures: these all mirror
+            # projects, and the scip-java build-tool test fixtures: these all mirror
             # real-world project layouts that must not be reformatted here.
             find . -name '*.java' \
               -not -path './examples/*' \
               -not -path './tests/minimized/*' \
               -not -path './tests/snapshots/*' \
-              -not -path './tests/buildTools/src/test/resources/fixtures/*' \
+              -not -path './scip-java/src/test/resources/fixtures/*' \
               -not -path './scip-kotlinc/minimized/*' \
               -exec ${pkgs.google-java-format}/bin/google-java-format --dry-run --set-exit-if-changed {} +
             touch $out
           '';
           ktfmt = pkgs.runCommand "check-ktfmt" { } ''
             cd ${./.}
             # Exclude minimized Kotlin snapshots (coupled to generated SCIP
-            # goldens with exact line/column annotations) and the buildTools test
-            # fixtures (real-world project layouts): neither may be reformatted.
+            # goldens with exact line/column annotations) and the scip-java
+            # build-tool test fixtures (real-world project layouts): neither may
+            # be reformatted.
             find . -name '*.kt' \
               -not -path './scip-kotlinc/minimized/*' \
-              -not -path './tests/buildTools/src/test/resources/fixtures/*' \
+              -not -path './scip-java/src/test/resources/fixtures/*' \
               -exec ${pkgs.ktfmt}/bin/ktfmt --kotlinlang-style --dry-run --set-exit-if-changed {} +
             touch $out
           '';