ci: remove disabled code quality upload

Author: aledbf

.github/workflows/go-cli.yml

@@ -16,7 +16,6 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      code-quality: write
     steps:
       - uses: actions/checkout@v7
       - uses: actions/setup-go@v7
@@ -39,19 +38,6 @@ jobs:
       - run: task build
       - run: ./devcontainer --version
 
-      # Convert the Go coverage profile (coverage.out) to Cobertura XML for
-      # GitHub's native Code Quality feature.
-      - name: Convert coverage to Cobertura XML
-        run: |
-          go install github.com/boumenot/gocover-cobertura@latest
-          gocover-cobertura < coverage.out > coverage.xml
-      - name: Upload coverage report
-        uses: actions/upload-code-coverage@v1
-        with:
-          file: coverage.xml
-          language: Go
-          label: code-coverage/go
-
       # Binary covdata for the cross-lane merge (coverage-report job).
       - uses: actions/upload-artifact@v7
         if: always()

internal/cli/code_quality_workflow_test.go

@@ -0,0 +1,23 @@
+package cli
+
+import (
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+)
+
+func TestGoCLIWorkflowDoesNotUploadDisabledCodeQualityCoverage(t *testing.T) {
+	workflowPath := filepath.Join("..", "..", ".github", "workflows", "go-cli.yml")
+	data, err := os.ReadFile(workflowPath)
+	if err != nil {
+		t.Fatalf("read %s: %v", workflowPath, err)
+	}
+
+	workflow := string(data)
+	for _, disabledSetting := range []string{"actions/upload-code-coverage", "code-quality: write"} {
+		if strings.Contains(workflow, disabledSetting) {
+			t.Errorf("%s still contains disabled Code Quality setting %q", workflowPath, disabledSetting)
+		}
+	}
+}