test: add row filter edge-case coverage

test: add row filter edge-case coverage

test/unit.c — 6 new test functions:
  1. do_test_row_filter_clear — Tests cloudsync_clear_filter (previously
     zero coverage): set filter, insert data, clear filter, verify
     unfiltered operations are tracked, sync to peer
  2. do_test_row_filter_complex_expressions — Tests AND + comparison,
     string literals with escaped quotes, IS NULL, IN (...), and sync
     roundtrip with compound filters
  3. do_test_row_filter_row_transition — Tests rows moving out of filter
     scope (UPDATE makes row non-matching → no metadata generated) and
     into filter scope (UPDATE makes row matching → metadata created),
     plus bidirectional sync with transitions
  4. do_test_row_filter_change — Tests changing filter expression after
     data exists: old metadata persists, new filter applies to new
     operations, updates under old filter conditions are not tracked
  5. do_test_row_filter_composite_pk_multi_table — Tests composite
     primary keys with filters, multiple tables with different filters
     (including string literal in filter), sync roundtrip, and
     update/delete on composite PK rows
  6. do_test_row_filter_prefill — Tests pre-existing data inserted
     before cloudsync_init and cloudsync_set_filter: verifies initial
     metatable fill includes all rows (no filter during refill), new
     operations after set_filter respect the filter, and sync roundtrip
     transfers all pre-existing rows plus only matching new rows

test/postgresql/47_row_filter_advanced.sql — 10 assertions covering
clear_filter, complex expressions, IS NULL, row transitions, and filter
change

test/postgresql/48_row_filter_multi_table.sql — 8 assertions covering
composite PKs, multi-column filters with string literals, multi-table
sync roundtrip, and update/delete on composite PKs

test/postgresql/49_row_filter_prefill.sql — 8 assertions covering
pre-existing data before init+set_filter, matching/non-matching insert
behavior after filter, sync roundtrip with refill metadata, and
composite PK prefill with filter

Author: andinux

test/postgresql/47_row_filter_advanced.sql

@@ -0,0 +1,192 @@
+-- 'Row-level filter advanced tests (clear, complex expressions, row transitions, filter change)'
+
+\set testid '47'
+\ir helper_test_init.sql
+
+-- Create database
+\connect postgres
+\ir helper_psql_conn_setup.sql
+DROP DATABASE IF EXISTS cloudsync_test_47_a;
+CREATE DATABASE cloudsync_test_47_a;
+
+\connect cloudsync_test_47_a
+\ir helper_psql_conn_setup.sql
+CREATE EXTENSION IF NOT EXISTS cloudsync;
+
+-- ============================================================
+-- Test 1: cloudsync_clear_filter lifecycle
+-- ============================================================
+CREATE TABLE tasks (id TEXT PRIMARY KEY NOT NULL, title TEXT, user_id INTEGER);
+SELECT cloudsync_init('tasks') AS _init \gset
+SELECT cloudsync_set_filter('tasks', 'user_id = 1') AS _sf \gset
+
+INSERT INTO tasks VALUES ('a', 'Task A', 1);
+INSERT INTO tasks VALUES ('b', 'Task B', 2);
+INSERT INTO tasks VALUES ('c', 'Task C', 1);
+
+-- Only matching rows tracked
+SELECT COUNT(DISTINCT pk) AS meta_pk_count FROM tasks_cloudsync \gset
+SELECT (:meta_pk_count = 2) AS clear_t1a_ok \gset
+\if :clear_t1a_ok
+\echo [PASS] (:testid) clear_filter: 2 PKs tracked before clear
+\else
+\echo [FAIL] (:testid) clear_filter: expected 2 tracked PKs before clear, got :meta_pk_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Clear filter
+SELECT cloudsync_clear_filter('tasks') AS _cf \gset
+
+-- Insert non-matching row — should now be tracked
+INSERT INTO tasks VALUES ('d', 'Task D', 2);
+SELECT COUNT(DISTINCT pk) AS meta_pk_count FROM tasks_cloudsync \gset
+SELECT (:meta_pk_count = 3) AS clear_t1b_ok \gset
+\if :clear_t1b_ok
+\echo [PASS] (:testid) clear_filter: non-matching row tracked after clear (3 PKs)
+\else
+\echo [FAIL] (:testid) clear_filter: expected 3 PKs after clear+insert, got :meta_pk_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Update previously-untracked row 'b' — should now be tracked
+UPDATE tasks SET title = 'Task B Updated' WHERE id = 'b';
+SELECT COUNT(DISTINCT pk) AS meta_pk_count FROM tasks_cloudsync \gset
+SELECT (:meta_pk_count = 4) AS clear_t1c_ok \gset
+\if :clear_t1c_ok
+\echo [PASS] (:testid) clear_filter: update on 'b' tracked after clear (4 PKs)
+\else
+\echo [FAIL] (:testid) clear_filter: expected 4 PKs after update on 'b', got :meta_pk_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 2: Complex filter — AND + comparison operators
+-- ============================================================
+DROP TABLE IF EXISTS items;
+CREATE TABLE items (id TEXT PRIMARY KEY NOT NULL, status TEXT, priority INTEGER, category TEXT, user_id INTEGER);
+SELECT cloudsync_init('items') AS _init \gset
+SELECT cloudsync_set_filter('items', 'user_id = 1 AND priority > 3') AS _sf \gset
+
+INSERT INTO items VALUES ('a', 'active', 5, 'work', 1);   -- matches
+INSERT INTO items VALUES ('b', 'active', 2, 'work', 1);   -- fails priority
+INSERT INTO items VALUES ('c', 'active', 5, 'work', 2);   -- fails user_id
+
+SELECT COUNT(DISTINCT pk) AS meta_pk_count FROM items_cloudsync \gset
+SELECT (:meta_pk_count = 1) AS complex_t2_ok \gset
+\if :complex_t2_ok
+\echo [PASS] (:testid) complex_filter: AND+comparison tracked 1 of 3 rows
+\else
+\echo [FAIL] (:testid) complex_filter: expected 1 tracked PK, got :meta_pk_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 3: IS NULL filter
+-- ============================================================
+SELECT cloudsync_clear_filter('items') AS _cf \gset
+SELECT cloudsync_set_filter('items', 'category IS NULL') AS _sf \gset
+
+SELECT COUNT(DISTINCT pk) AS meta_before FROM items_cloudsync \gset
+INSERT INTO items VALUES ('f', 'x', 1, NULL, 1);       -- matches
+INSERT INTO items VALUES ('g', 'x', 1, 'work', 1);     -- fails
+SELECT COUNT(DISTINCT pk) AS meta_after FROM items_cloudsync \gset
+SELECT ((:meta_after::int - :meta_before::int) = 1) AS null_t3_ok \gset
+\if :null_t3_ok
+\echo [PASS] (:testid) IS NULL filter: only NULL-category row tracked
+\else
+\echo [FAIL] (:testid) IS NULL filter: expected 1 new PK, got (:meta_after - :meta_before)
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 4: Row exits filter (matching -> non-matching via UPDATE)
+-- ============================================================
+DROP TABLE IF EXISTS trans;
+CREATE TABLE trans (id TEXT PRIMARY KEY NOT NULL, title TEXT, user_id INTEGER);
+SELECT cloudsync_init('trans') AS _init \gset
+SELECT cloudsync_set_filter('trans', 'user_id = 1') AS _sf \gset
+
+INSERT INTO trans VALUES ('a', 'Task A', 1);
+
+SELECT COUNT(*) AS meta_before FROM trans_cloudsync \gset
+UPDATE trans SET user_id = 2 WHERE id = 'a';
+SELECT COUNT(*) AS meta_after FROM trans_cloudsync \gset
+SELECT (:meta_before = :meta_after) AS exit_t4_ok \gset
+\if :exit_t4_ok
+\echo [PASS] (:testid) row_exit: UPDATE out of filter did not change metadata
+\else
+\echo [FAIL] (:testid) row_exit: UPDATE out of filter changed metadata (:meta_before -> :meta_after)
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 5: Row enters filter (non-matching -> matching via UPDATE)
+-- ============================================================
+INSERT INTO trans VALUES ('b', 'Task B', 2);
+
+SELECT COUNT(DISTINCT pk) AS meta_before FROM trans_cloudsync \gset
+UPDATE trans SET user_id = 1 WHERE id = 'b';
+SELECT COUNT(DISTINCT pk) AS meta_after FROM trans_cloudsync \gset
+SELECT (:meta_after::int > :meta_before::int) AS enter_t5_ok \gset
+\if :enter_t5_ok
+\echo [PASS] (:testid) row_enter: UPDATE into filter created metadata
+\else
+\echo [FAIL] (:testid) row_enter: UPDATE into filter did not create metadata (:meta_before -> :meta_after)
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 6: Filter change after data
+-- ============================================================
+DROP TABLE IF EXISTS fchange;
+CREATE TABLE fchange (id TEXT PRIMARY KEY NOT NULL, title TEXT, user_id INTEGER);
+SELECT cloudsync_init('fchange') AS _init \gset
+SELECT cloudsync_set_filter('fchange', 'user_id = 1') AS _sf \gset
+
+INSERT INTO fchange VALUES ('a', 'A', 1);  -- matches
+INSERT INTO fchange VALUES ('b', 'B', 2);  -- non-matching
+INSERT INTO fchange VALUES ('c', 'C', 1);  -- matches
+
+SELECT COUNT(DISTINCT pk) AS meta_count FROM fchange_cloudsync \gset
+SELECT (:meta_count = 2) AS change_t6a_ok \gset
+\if :change_t6a_ok
+\echo [PASS] (:testid) filter_change: 2 PKs under initial filter
+\else
+\echo [FAIL] (:testid) filter_change: expected 2 PKs under initial filter, got :meta_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Change filter
+SELECT cloudsync_set_filter('fchange', 'user_id = 2') AS _sf2 \gset
+
+INSERT INTO fchange VALUES ('d', 'D', 2);  -- matches new filter
+INSERT INTO fchange VALUES ('e', 'E', 1);  -- non-matching under new filter
+
+SELECT COUNT(DISTINCT pk) AS meta_count FROM fchange_cloudsync \gset
+SELECT (:meta_count = 3) AS change_t6b_ok \gset
+\if :change_t6b_ok
+\echo [PASS] (:testid) filter_change: 3 PKs after filter change (old metadata persists)
+\else
+\echo [FAIL] (:testid) filter_change: expected 3 PKs after filter change, got :meta_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Update 'a' (user_id=1) should NOT generate new metadata under new filter (user_id=2)
+SELECT COUNT(*) AS meta_before FROM fchange_cloudsync \gset
+UPDATE fchange SET title = 'A Updated' WHERE id = 'a';
+SELECT COUNT(*) AS meta_after FROM fchange_cloudsync \gset
+SELECT (:meta_before = :meta_after) AS change_t6c_ok \gset
+\if :change_t6c_ok
+\echo [PASS] (:testid) filter_change: update on 'a' not tracked under new filter
+\else
+\echo [FAIL] (:testid) filter_change: update on 'a' changed metadata (:meta_before -> :meta_after)
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Cleanup
+\ir helper_test_cleanup.sql
+\if :should_cleanup
+DROP DATABASE IF EXISTS cloudsync_test_47_a;
+\else
+\echo [INFO] !!!!!
+\endif

test/postgresql/48_row_filter_multi_table.sql

@@ -0,0 +1,166 @@
+-- 'Row-level filter: multi-table with different filters and composite primary keys'
+
+\set testid '48'
+\ir helper_test_init.sql
+
+-- Create databases
+\connect postgres
+\ir helper_psql_conn_setup.sql
+DROP DATABASE IF EXISTS cloudsync_test_48_a;
+DROP DATABASE IF EXISTS cloudsync_test_48_b;
+CREATE DATABASE cloudsync_test_48_a;
+CREATE DATABASE cloudsync_test_48_b;
+
+-- ============================================================
+-- Setup Database A
+-- ============================================================
+\connect cloudsync_test_48_a
+\ir helper_psql_conn_setup.sql
+CREATE EXTENSION IF NOT EXISTS cloudsync;
+
+-- Table 1: composite PK with simple filter
+CREATE TABLE projects (org_id INTEGER NOT NULL, proj_id INTEGER NOT NULL, name TEXT, PRIMARY KEY(org_id, proj_id));
+SELECT cloudsync_init('projects') AS _init \gset
+SELECT cloudsync_set_filter('projects', 'org_id = 1') AS _sf \gset
+
+-- Table 2: composite PK with multi-column filter including string literal
+CREATE TABLE members (org_id INTEGER NOT NULL, user_id INTEGER NOT NULL, role TEXT, PRIMARY KEY(org_id, user_id));
+SELECT cloudsync_init('members') AS _init \gset
+SELECT cloudsync_set_filter('members', 'org_id = 1 AND role = ''admin''') AS _sf \gset
+
+-- ============================================================
+-- Test 1: Composite PK — only matching rows tracked
+-- ============================================================
+INSERT INTO projects VALUES (1, 1, 'Proj A');   -- matches
+INSERT INTO projects VALUES (2, 1, 'Proj B');   -- fails org_id
+INSERT INTO projects VALUES (1, 2, 'Proj C');   -- matches
+
+SELECT COUNT(DISTINCT pk) AS proj_meta FROM projects_cloudsync \gset
+SELECT (:proj_meta = 2) AS t1_proj_ok \gset
+\if :t1_proj_ok
+\echo [PASS] (:testid) composite_pk: 2 of 3 projects tracked
+\else
+\echo [FAIL] (:testid) composite_pk: expected 2 project PKs, got :proj_meta
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 2: Multi-column filter with string literal — different table
+-- ============================================================
+INSERT INTO members VALUES (1, 10, 'admin');    -- matches both conditions
+INSERT INTO members VALUES (1, 20, 'viewer');   -- fails role
+INSERT INTO members VALUES (2, 10, 'admin');    -- fails org_id
+
+SELECT COUNT(DISTINCT pk) AS mem_meta FROM members_cloudsync \gset
+SELECT (:mem_meta = 1) AS t2_mem_ok \gset
+\if :t2_mem_ok
+\echo [PASS] (:testid) multi_filter: 1 of 3 members tracked
+\else
+\echo [FAIL] (:testid) multi_filter: expected 1 member PK, got :mem_meta
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 3: Roundtrip sync — only matching rows per table transfer
+-- ============================================================
+SELECT encode(cloudsync_payload_encode(tbl, pk, col_name, col_value, col_version, db_version, site_id, cl, seq), 'hex') AS payload_hex
+FROM cloudsync_changes
+WHERE site_id = cloudsync_siteid() \gset
+
+\connect cloudsync_test_48_b
+\ir helper_psql_conn_setup.sql
+CREATE EXTENSION IF NOT EXISTS cloudsync;
+
+CREATE TABLE projects (org_id INTEGER NOT NULL, proj_id INTEGER NOT NULL, name TEXT, PRIMARY KEY(org_id, proj_id));
+SELECT cloudsync_init('projects') AS _init \gset
+SELECT cloudsync_set_filter('projects', 'org_id = 1') AS _sf \gset
+
+CREATE TABLE members (org_id INTEGER NOT NULL, user_id INTEGER NOT NULL, role TEXT, PRIMARY KEY(org_id, user_id));
+SELECT cloudsync_init('members') AS _init \gset
+SELECT cloudsync_set_filter('members', 'org_id = 1 AND role = ''admin''') AS _sf \gset
+
+SELECT cloudsync_payload_apply(decode(:'payload_hex', 'hex')) AS _apply \gset
+
+-- Verify projects
+SELECT COUNT(*) AS proj_count FROM projects \gset
+SELECT (:proj_count = 2) AS t3_proj_ok \gset
+\if :t3_proj_ok
+\echo [PASS] (:testid) roundtrip: 2 projects synced to db_b
+\else
+\echo [FAIL] (:testid) roundtrip: expected 2 projects in db_b, got :proj_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Verify members
+SELECT COUNT(*) AS mem_count FROM members \gset
+SELECT (:mem_count = 1) AS t3_mem_ok \gset
+\if :t3_mem_ok
+\echo [PASS] (:testid) roundtrip: 1 member synced to db_b
+\else
+\echo [FAIL] (:testid) roundtrip: expected 1 member in db_b, got :mem_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Verify correct member identity
+SELECT COUNT(*) AS admin_exists FROM members WHERE org_id = 1 AND user_id = 10 AND role = 'admin' \gset
+SELECT (:admin_exists = 1) AS t3_admin_ok \gset
+\if :t3_admin_ok
+\echo [PASS] (:testid) roundtrip: correct admin member (1,10) present
+\else
+\echo [FAIL] (:testid) roundtrip: admin member (1,10) not found
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Non-matching rows should NOT exist
+SELECT COUNT(*) AS bad_proj FROM projects WHERE org_id = 2 \gset
+SELECT (:bad_proj = 0) AS t3_no_bad_proj \gset
+\if :t3_no_bad_proj
+\echo [PASS] (:testid) roundtrip: no org_id=2 projects in db_b
+\else
+\echo [FAIL] (:testid) roundtrip: unexpected org_id=2 projects found (:bad_proj)
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- ============================================================
+-- Test 4: Update and delete on composite PK, then re-sync
+-- ============================================================
+\connect cloudsync_test_48_a
+\ir helper_psql_conn_setup.sql
+
+UPDATE projects SET name = 'Proj A Updated' WHERE org_id = 1 AND proj_id = 1;
+DELETE FROM projects WHERE org_id = 1 AND proj_id = 2;
+
+SELECT encode(cloudsync_payload_encode(tbl, pk, col_name, col_value, col_version, db_version, site_id, cl, seq), 'hex') AS payload2_hex
+FROM cloudsync_changes
+WHERE site_id = cloudsync_siteid() \gset
+
+\connect cloudsync_test_48_b
+\ir helper_psql_conn_setup.sql
+SELECT cloudsync_payload_apply(decode(:'payload2_hex', 'hex')) AS _apply2 \gset
+
+SELECT COUNT(*) AS proj_count FROM projects \gset
+SELECT (:proj_count = 1) AS t4_count_ok \gset
+\if :t4_count_ok
+\echo [PASS] (:testid) update_delete: 1 project remaining after sync
+\else
+\echo [FAIL] (:testid) update_delete: expected 1 project, got :proj_count
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+SELECT COUNT(*) AS updated_exists FROM projects WHERE org_id = 1 AND proj_id = 1 AND name = 'Proj A Updated' \gset
+SELECT (:updated_exists = 1) AS t4_updated_ok \gset
+\if :t4_updated_ok
+\echo [PASS] (:testid) update_delete: 'Proj A Updated' present in db_b
+\else
+\echo [FAIL] (:testid) update_delete: 'Proj A Updated' not found in db_b
+SELECT (:fail::int + 1) AS fail \gset
+\endif
+
+-- Cleanup
+\ir helper_test_cleanup.sql
+\if :should_cleanup
+DROP DATABASE IF EXISTS cloudsync_test_48_a;
+DROP DATABASE IF EXISTS cloudsync_test_48_b;
+\else
+\echo [INFO] !!!!!
+\endif