chore(mongodbflex): move nil checks in outputResult into pretty print function, change version to value type

Author: SerseusWasTaken

internal/cmd/mongodbflex/backup/describe/describe.go

@@ -119,10 +119,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *mongodbflex
 }
 
 func outputResult(p *print.Printer, outputFormat, restoreStatus string, backup *mongodbflex.Backup) error {
-	if backup == nil {
-		return fmt.Errorf("API response is nil")
-	}
 	return p.OutputResult(outputFormat, backup, func() error {
+		if backup == nil {
+			return fmt.Errorf("API response is nil")
+		}
 		table := tables.NewTable()
 		table.AddRow("ID", utils.PtrString(backup.Id))
 		table.AddSeparator()

internal/cmd/mongodbflex/instance/create/create.go

@@ -59,7 +59,7 @@ type inputModel struct {
 	RAM            *int32
 	StorageClass   *string
 	StorageSize    *int64
-	Version        *string
+	Version        string
 	Type           *string
 }
 
@@ -107,12 +107,12 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 			}
 
 			// Fill in version, if needed
-			if model.Version == nil {
+			if model.Version == "" {
 				version, err := mongodbflexUtils.GetLatestMongoDBVersion(ctx, apiClient.DefaultAPI, model.ProjectId, model.Region)
 				if err != nil {
 					return fmt.Errorf("get latest MongoDB version: %w", err)
 				}
-				model.Version = &version
+				model.Version = version
 			}
 
 			// Call API
@@ -193,7 +193,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 		RAM:             ram,
 		StorageClass:    utils.Ptr(flags.FlagWithDefaultToStringValue(p, cmd, storageClassFlag)),
 		StorageSize:     &storageSize,
-		Version:         flags.FlagToStringPointer(p, cmd, versionFlag),
+		Version:         flags.FlagToStringValue(p, cmd, versionFlag),
 		Type:            typeFlag.Ptr(),
 	}
 
@@ -259,7 +259,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient MongoDBFlexC
 			Class: model.StorageClass,
 			Size:  model.StorageSize,
 		},
-		Version: *model.Version,
+		Version: model.Version,
 		Options: map[string]string{
 			"type": *model.Type,
 		},

internal/cmd/mongodbflex/instance/create/create_test.go

@@ -83,7 +83,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 		FlavorId:       utils.Ptr(testFlavorId),
 		StorageClass:   utils.Ptr("premium-perf4-mongodb"),
 		StorageSize:    utils.Ptr(int64(10)),
-		Version:        utils.Ptr("6.0"),
+		Version:        "6.0",
 		Type:           utils.Ptr("Replica"),
 	}
 	for _, mod := range mods {
@@ -216,7 +216,7 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: true,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.Version = nil
+				model.Version = ""
 			}),
 		},
 		{

internal/cmd/mongodbflex/instance/describe/describe.go

@@ -92,11 +92,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *mongodbflex
 }
 
 func outputResult(p *print.Printer, outputFormat string, instance *mongodbflex.Instance) error {
-	if instance == nil {
-		return fmt.Errorf("instance is nil")
-	}
-
 	return p.OutputResult(outputFormat, instance, func() error {
+		if instance == nil {
+			return fmt.Errorf("instance is nil")
+		}
 		var instanceType string
 		if instance.HasReplicas() {
 			var err error