review changes 2

Author: h3adex

internal/cmd/routingtable/update/update.go

@@ -117,7 +117,8 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool(systemRoutesFlag, false, "If set to false, disables routes for project-to-project communication.")
 	cmd.Flags().Var(flags.UUIDFlag(), organizationIdFlag, "Organization ID")
 
-	err := flags.MarkFlagsRequired(cmd, organizationIdFlag, networkAreaIdFlag, dynamicRoutesFlag, systemRoutesFlag, nameFlag)
+	err := flags.MarkFlagsRequired(cmd, organizationIdFlag, networkAreaIdFlag)
+	cmd.MarkFlagsOneRequired(dynamicRoutesFlag, systemRoutesFlag, nameFlag, descriptionFlag, labelFlag)
 	cobra.CheckErr(err)
 }
 

internal/cmd/routingtable/update/update_test.go

@@ -168,28 +168,44 @@ func TestParseInput(t *testing.T) {
 			isValid: false,
 		},
 		{
-			description: "dynamic-route-flag missing",
-			argValues:   []string{testRoutingTableId},
+			description: "org-id missing",
+			argValues:   fixtureArgValues(),
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, dynamicRoutesFlag)
+				delete(flagValues, organizationIdFlag)
 			}),
 			isValid: false,
 		},
 		{
-			description: "system-routes-flag missing",
+			description: "all required flags missing",
 			argValues:   []string{testRoutingTableId},
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, dynamicRoutesFlag)
 				delete(flagValues, systemRoutesFlag)
+				delete(flagValues, nameFlag)
+				delete(flagValues, labelFlag)
+				delete(flagValues, descriptionFlag)
 			}),
 			isValid: false,
 		},
 		{
-			description: "org-id missing",
-			argValues:   fixtureArgValues(),
+			description: "all except one required flag missing",
+			argValues:   []string{testRoutingTableId},
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, organizationIdFlag)
+				delete(flagValues, dynamicRoutesFlag)
+				delete(flagValues, systemRoutesFlag)
+				delete(flagValues, nameFlag)
+				delete(flagValues, labelFlag)
+				// delete(flagValues, descriptionFlag)
 			}),
-			isValid: false,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.RoutingTableId = testRoutingTableId
+				model.DynamicRoutes = nil
+				model.SystemRoutes = nil
+				model.Labels = nil
+				model.Name = nil
+				model.Description = utils.Ptr(testRoutingTableDescription)
+			}),
+			isValid: true,
 		},
 		{
 			description:   "arg value missing",