Skip to content

Commit 8139ff2

Browse files
tgrunnagleclaude
andcommitted
Address code review feedback for operator architecture docs
Fix issues found during code review of #4642 documentation: - HIGH: Fix remoteURL to remoteUrl in MCPRemoteProxy YAML example to match actual JSON tag (per camelCase rename in 992f2e4) - MEDIUM: Replace non-standard Mermaid -..-> arrow syntax with standard -.-> for authServerRef edges - MEDIUM: Add missing telemetryConfigRef to MCPRemoteProxy key fields list, Mermaid diagram, and Referenced by section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 753b016 commit 8139ff2

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

docs/arch/09-operator-architecture.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,14 @@ graph TB
133133
134134
Server -->|groupRef| Group
135135
Server -.->|externalAuthConfigRef| ExtAuth
136-
Server -..->|authServerRef| ExtAuth
136+
Server -.->|authServerRef| ExtAuth
137137
Server -.->|toolConfigRef| ToolCfg
138138
Server -.->|oidcConfigRef| OIDCCfg
139139
Server -.->|telemetryConfigRef| TelCfg
140140
141141
Proxy -->|groupRef| Group
142142
Proxy -.->|externalAuthConfigRef| ExtAuth
143-
Proxy -..->|authServerRef| ExtAuth
143+
Proxy -.->|authServerRef| ExtAuth
144144
Proxy -.->|toolConfigRef| ToolCfg
145145
Proxy -.->|oidcConfigRef| OIDCCfg
146146
Proxy -.->|telemetryConfigRef| TelCfg
@@ -269,6 +269,7 @@ Defines a proxy for remote MCP servers with authentication, authorization, audit
269269
- `externalAuthConfigRef` - Outgoing auth for remote service authentication (token exchange, AWS STS, bearer token injection)
270270
- `authServerRef` - Incoming auth via the embedded OAuth 2.0/OIDC authorization server (references an MCPExternalAuthConfig of type `embeddedAuthServer`)
271271
- `authzConfig` - Authorization policies
272+
- `telemetryConfigRef` - Reference to shared MCPTelemetryConfig (replaces deprecated inline `telemetry`)
272273
- `toolConfigRef` - Tool filtering and renaming
273274

274275
OIDC is optional — omit `oidcConfigRef` for unauthenticated proxies.
@@ -282,7 +283,7 @@ kind: MCPRemoteProxy
282283
metadata:
283284
name: bedrock-proxy
284285
spec:
285-
remoteURL: https://bedrock-mcp.example.com
286+
remoteUrl: https://bedrock-mcp.example.com
286287
authServerRef:
287288
kind: MCPExternalAuthConfig
288289
name: my-auth-server # type: embeddedAuthServer

0 commit comments

Comments
 (0)