add error feedback if obs64 exe is missing

* controller.cpp: Adding new exitcode that represents
the obs64 exe could not be found. Updating JS code
to properly check the exitCode to avoid a silent
failure case
* utility.hpp: Output to error stream when connection fails.
Previously, the code attempted to return a JS
exception but it never got to run due to the exit(1).
This way we maintain legacy behavior and exit
application with a helpful message
* module.js: verify bin folder contains obs64

Author: sandboxcoder

js/module.js

@@ -121,11 +121,11 @@ function getSourcesSize(sourcesNames) {
     return sourcesSize;
 }
 exports.getSourcesSize = getSourcesSize;
-const __dirnameApple = hasDeveloperApp
+const appleBinaryFolder = hasDeveloperApp
   ? path.join(__dirname, 'OSN.app', 'distribute', 'obs-studio-node', 'bin')
   : path.join(__dirname, 'bin');
-if (fs.existsSync(path.resolve(__dirnameApple).replace('app.asar', 'app.asar.unpacked'))) {
-    obs.IPC.setServerPath(path.resolve(__dirnameApple, `obs64`).replace('app.asar', 'app.asar.unpacked'), path.resolve(__dirnameApple).replace('app.asar', 'app.asar.unpacked'));
+if (fs.existsSync(path.resolve(appleBinaryFolder, 'obs64').replace('app.asar', 'app.asar.unpacked'))) {
+    obs.IPC.setServerPath(path.resolve(appleBinaryFolder, `obs64`).replace('app.asar', 'app.asar.unpacked'), path.resolve(appleBinaryFolder).replace('app.asar', 'app.asar.unpacked'));
 }
 else if (fs.existsSync(path.resolve(__dirname, `obs64.exe`).replace('app.asar', 'app.asar.unpacked'))) {
     obs.IPC.setServerPath(path.resolve(__dirname, `obs64.exe`).replace('app.asar', 'app.asar.unpacked'), path.resolve(__dirname).replace('app.asar', 'app.asar.unpacked'));

js/module.ts

@@ -1899,11 +1899,11 @@ export const enum VCamOutputType {
 };
 
 // Initialization and other stuff which needs local data.
-const __dirnameApple = hasDeveloperApp
+const appleBinaryFolder = hasDeveloperApp
   ? path.join(__dirname, 'OSN.app', 'distribute', 'obs-studio-node', 'bin')
   : path.join(__dirname, 'bin');
-if (fs.existsSync(path.resolve(__dirnameApple).replace('app.asar', 'app.asar.unpacked'))) {
-    obs.IPC.setServerPath(path.resolve(__dirnameApple, `obs64`).replace('app.asar', 'app.asar.unpacked'), path.resolve(__dirnameApple).replace('app.asar', 'app.asar.unpacked'));
+if (fs.existsSync(path.resolve(appleBinaryFolder, 'obs64').replace('app.asar', 'app.asar.unpacked'))) {
+    obs.IPC.setServerPath(path.resolve(appleBinaryFolder, `obs64`).replace('app.asar', 'app.asar.unpacked'), path.resolve(appleBinaryFolder).replace('app.asar', 'app.asar.unpacked'));
 }
 else if (fs.existsSync(path.resolve(__dirname, `obs64.exe`).replace('app.asar', 'app.asar.unpacked'))) {
     obs.IPC.setServerPath(path.resolve(__dirname, `obs64.exe`).replace('app.asar', 'app.asar.unpacked'), path.resolve(__dirname).replace('app.asar', 'app.asar.unpacked'));

obs-studio-client/source/controller.cpp

@@ -449,7 +449,9 @@ Napi::Value js_connect(const Napi::CallbackInfo &info)
 	if (exit_code == STATUS_DLL_NOT_FOUND)
 		exit_code = ProcessInfo::MISSING_DEPENDENCY;
 #endif
-
+	if (exit_code == 0 && cl == nullptr) {
+		exit_code = ProcessInfo::OTHER_ERROR; // Null ipc client which can be caused due to missing obs64
+	}
 	return Napi::Number::New(info.Env(), exit_code);
 }
 
@@ -475,6 +477,9 @@ Napi::Value js_host(const Napi::CallbackInfo &info)
 		exit_code = ProcessInfo::MISSING_DEPENDENCY;
 #endif
 
+	if (exit_code == 0 && cl == nullptr) {
+		exit_code = ProcessInfo::OTHER_ERROR; // Null ipc client which can be caused due to missing obs64
+	}
 	return Napi::Number::New(info.Env(), exit_code);
 }
 

obs-studio-client/source/utility.hpp

@@ -122,7 +122,7 @@ static FORCE_INLINE std::shared_ptr<ipc::client> GetConnection(const Napi::Callb
 {
 	auto conn = Controller::GetInstance().GetConnection();
 	if (!conn) {
-		Napi::Error::New(info.Env(), "Failed to obtain IPC connection.").ThrowAsJavaScriptException();
+		std::cerr << "Failed to obtain IPC connection." << std::endl;
 		exit(1);
 	}
 	return conn;

tests/osn-tests/util/obs_handler.ts

@@ -108,7 +108,13 @@ export class OBSHandler {
         logInfo(this.osnTestName, 'Initializing OBS');
 
         try {
-            osn.NodeObs.IPC.host(this.pipeName);
+            const exitCode = osn.NodeObs.IPC.host(this.pipeName);
+            if (exitCode != osn.EVideoCodes.Success) {
+                if (exitCode == osn.EIPCError.OTHER_ERROR) {
+                    throw Error('OBS IPC host failed: missing executable or some other error.');
+                }
+                throw Error(`OBS IPC host failed with code ${exitCode}. See osn.EIPCError for more details.`);
+            }
             osn.NodeObs.SetWorkingDirectory(this.workingDirectory);
             initResult = osn.NodeObs.OBS_API_initAPI(this.language, this.obsPath, this.version, this.crashServer);
         } catch (e) {