Repository navigation
Dedup retried Nexus signals - #2036
Merged
Merged
Conversation
atol
marked this pull request as ready for review
October 30, 2026 15:52
atol
force-pushed
the
alicelin/NEXUS-940/signal-dedup
branch
from
November 3, 2026 21:03
fe91ac8 to
d7ca329
Compare
VegetarianOrc
requested changes
Nov 4, 2026
atol
force-pushed
the
alicelin/NEXUS-940/signal-dedup
branch
from
November 5, 2026 19:37
d7ca329 to
0f3b9f5
Compare
VegetarianOrc
approved these changes
Nov 5, 2026
VegetarianOrc
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Ty for the changes! Just a couple of nits I'd consider before merging.
Comment on lines
+204
to
+208
| token = _temporal_operation_signal_slot.set(_SignalSlot()) | ||
| try: | ||
| result = await self.start_operation(start_ctx, nexus_client, input) | ||
| finally: | ||
| _temporal_operation_signal_slot.reset(token) |
Contributor
There was a problem hiding this comment.
nit, but I'd prefer this encapsulated in a context manager that manages the signal slot context var. could be a static method on _SignalSlot so we could do like
with _SignalSlot.limit_signals():
result = await self.start_operation(start_ctx, nexus_client, input)
atol
force-pushed
the
alicelin/NEXUS-940/signal-dedup
branch
from
November 6, 2026 18:17
c4ef27c to
2ddc554
Compare
Co-authored-by: Alex Mazzeo <alex.mazzeo@temporal.io>
atol
force-pushed
the
alicelin/NEXUS-940/signal-dedup
branch
from
November 6, 2026 22:34
2ddc554 to
abcb22c
Compare
Contributor
Author
|
Moving the dedup into |
VegetarianOrc
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
TemporalNexusClient.clientin a Temporal operation handler now reuse the Nexus operation's request ID.BAD_REQUESTnexusrpc.HandlerError. (Signal-with-start counts toward the limit; a failed signal doesn't; a retried Nexus task starts with a fresh limit.)temporalio.nexus.client()are unchanged.Why?
When a Nexus task is retried, the handler reruns and sends its signal again with a new random request ID, so the workflow receives it twice. Reusing the operation's request ID lets the server dedupe the retry. However, every signal in one handler run then shares that ID, so a second signal to the same workflow would be silently dropped while reported as delivered. Limiting each run to one signal turns that silent loss into a clear error.
Checklist
How was this tested:
Added integration tests.
Any docs updates needed?
No.