Image dispatcher loads wrong function signatures on PHP 8.3

[acabal]

Consider the dispatcher for image functions:

safe/generated/image.php

Lines 9 to 11 in 6ea6a5b

	if (str_starts_with(PHP_VERSION, "8.3.")) {
	require_once __DIR__ . '/8.2/image.php';
	}

If a machine is running PHP 8.3, the dispatcher loads the PHP 8.2 signatures for image functions.

However this is incorrect for imagerotate(). In PHP <= 8.2, imagerotate() accepts 4 arguments, but in PHP >= 8.3 it accepts 3 arguments. Therefore, on a machine running PHP 8.3, Safe loads 8.2's old signatures and passes the function 4 arguments when it only accepts 3, causing breakage.

[acabal]

A quick fix might be:

--- a/generated/8.2/image.php
+++ b/generated/8.2/image.php
@@ -1291,7 +1291,12 @@ function imagerotate(\GdImage $image, float $angle, int $background_color, bool
{
   error_clear_last();
-    $safeResult = \imagerotate($image, $angle, $background_color, $ignore_transparent);
+    if (PHP_VERSION_ID >= 80300) {
+        $safeResult = \imagerotate($image, $angle, $background_color);
+    } else {
+        $safeResult = \imagerotate($image, $angle, $background_color, $ignore_transparent);
+    }
   if ($safeResult === false) {
       throw ImageException::createFromPhpError();
   }

I can open a PR if you want.

[shish]

Directly editing the generated files will mean the changes disappear next time they get regenerated - a fix needs to be figuring out why the generator thinks that the 8.2 and 8.3 functions are identical (my guess is the docs are wrong in the snapshot we're using, and maybe using a slightly-newer-but-not-too-new snapshot would get it right...)