Latest Release Branch Build Error Due to Using Older Version of GRPC Module

[estliu]

Hi, I have noticed the latest master/ tidb release branch have been using an older version of grpc module google.golang.org/grpc and specifically, this older version was using a function that was removed in the latest grpc module and causing build errors

Error: /home/runner/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20251110064850-747c298c5da2/internal/client/conn_pool.go:145:37: undefined: experimental.WithRecvBufferPool
Error: /home/runner/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20251110064850-747c298c5da2/internal/client/conn_pool.go:145:61: undefined: grpc.NewSharedBufferPool
Error: Process completed with exit code 1.

I have made one example change in #1792

[ti-chi-bot]

Welcome @estliu! It looks like this is your first issue to tikv/client-go 🎉

[you06]

Thanks for report. Since the grpc version of TiDB release-8.5 and master branches is still v1.63.2, there should be no build issues.

I can build TiDB with both release-8.5 and master branches in my develop environment.

Can you provide more information about the build failure? Did you upgrade "google.golang.org/grpc" in your codebase?

[estliu]

yes the issue is that my code base is using a later version of grpc. there are many libraries and features we used relying on a new version of grpc so i think to avoid version incompatibility, its better that the tikv library can support a later version of google.golang.org/grpc

[dveeden]

Note that for TiDB github.com/apache/arrow-go/v18@v18.0.0 requires google.golang.org/grpc@v1.67.1

This is "fixed" by replacing it: https://github.com/pingcap/tidb/blob/eeee02deea7f74a6dde92d7e5bdcb18ebdfa2fde/go.mod#L363-L364

I think it would be good to try to get rid of the replacement line.

The version used here: https://pkg.go.dev/google.golang.org/grpc@v1.63.2/experimental
This seems to be vulnerable to https://pkg.go.dev/vuln/GO-2024-2978
Looks like the renaming happened in https://pkg.go.dev/google.golang.org/grpc@v1.66.0/experimental

[estliu]

hi @you06 sorry for bumping this, it seems like as Dveeden mentioned above, there are two issues created regarding the version problem.