chore(webapp): scope component effect synchronization (#4727)

## Summary

Scopes React Compiler diagnostics for component and hook effects that
intentionally synchronize with navigation, submissions, browser APIs,
streams, timers, or authoritative server values. Each suppression stays
on the reported synchronization call rather than disabling analysis for
the component.

Author: carderne

apps/webapp/app/components/AskAI.tsx

@@ -273,6 +273,7 @@ function ChatMessages({
   // Reset feedback state when conversation is reset
   useEffect(() => {
     if (conversation.length === 0) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setFeedbackGivenForQAs(new Set());
     }
   }, [conversation.length]);

apps/webapp/app/components/DevPresence.tsx

@@ -55,6 +55,7 @@ export function DevPresenceProvider({ children, enabled = true }: DevPresencePro
   useEffect(() => {
     // If disabled or no events
     if (!enabled || streamedEvents === null) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setIsConnected(undefined);
       return;
     }
@@ -113,6 +114,7 @@ export function useCrossEngineIsConnected({
 
   useEffect(() => {
     if (project.engine === "V2") {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setCrossEngineIsConnected(isConnected);
       return;
     }

apps/webapp/app/components/Feedback.tsx

@@ -76,6 +76,7 @@ export function Feedback({
   useEffect(() => {
     const open = searchParams.get("feedbackPanel");
     if (open) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setType(open as FeedbackType);
       setOpen(true);
       // Clone instead of mutating in place

apps/webapp/app/components/LoginPageLayout.tsx

@@ -47,6 +47,7 @@ export function LoginPageLayout({
   const [randomQuote, setRandomQuote] = useState<QuoteType | null>(null);
   useEffect(() => {
     const randomIndex = Math.floor(Math.random() * quotes.length);
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     setRandomQuote(quotes[randomIndex]);
   }, []);
 

apps/webapp/app/components/TriggerRotatingLogo.tsx

@@ -25,6 +25,7 @@ export function TriggerRotatingLogo() {
   useEffect(() => {
     // Already registered from a previous render
     if (customElements.get("spline-viewer")) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setIsSplineReady(true);
       return;
     }

apps/webapp/app/components/admin/FeatureFlagsDialog.tsx

@@ -67,6 +67,7 @@ export function FeatureFlagsDialog({
 
   useEffect(() => {
     if (open && orgId) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setSaveError(null);
       setOverrides({});
       setInitialOverrides({});
@@ -77,6 +78,7 @@ export function FeatureFlagsDialog({
   useEffect(() => {
     if (loadFetcher.data) {
       const loaded = loadFetcher.data.orgFlags ?? {};
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setOverrides({ ...loaded });
       setInitialOverrides({ ...loaded });
     }
@@ -86,6 +88,7 @@ export function FeatureFlagsDialog({
     if (saveFetcher.data?.success) {
       onOpenChangeRef.current(false);
     } else if (saveFetcher.data?.error) {
+      // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
       setSaveError(saveFetcher.data.error);
     }
   }, [saveFetcher.data]);

apps/webapp/app/components/admin/backOffice/MaxProjectsSection.tsx

@@ -34,10 +34,12 @@ export function MaxProjectsSection({
   const [value, setValue] = useState(String(maximumProjectCount));
 
   useEffect(() => {
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     if (hasFieldErrors) setIsEditing(true);
   }, [hasFieldErrors]);
 
   useEffect(() => {
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     if (savedJustNow && !hasFieldErrors) setIsEditing(false);
   }, [savedJustNow, hasFieldErrors]);
 

apps/webapp/app/components/admin/backOffice/RateLimitSection.tsx

@@ -65,10 +65,12 @@ export function RateLimitSection({
   const [maxTokens, setMaxTokens] = useState(current ? String(current.maxTokens) : "");
 
   useEffect(() => {
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     if (hasFieldErrors) setIsEditing(true);
   }, [hasFieldErrors]);
 
   useEffect(() => {
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     if (savedJustNow && !hasFieldErrors) setIsEditing(false);
   }, [savedJustNow, hasFieldErrors]);
 

apps/webapp/app/components/billing/BillingAlertsSection.tsx

@@ -119,6 +119,7 @@ export function BillingAlertsSection({
       return;
     }
 
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     setShowResetBanner(true);
 
     if (searchParams.get("alertsReset") !== "1") {
@@ -189,6 +190,7 @@ export function BillingAlertsSection({
 
   useEffect(() => {
     nextThresholdIdRef.current = savedThresholds.length;
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     setThresholdRows(toThresholdRows(savedThresholds));
     setEmailValues(savedEmails.length > 0 ? [...savedEmails, ""] : [""]);
   }, [savedThresholds, savedEmails]);

apps/webapp/app/components/billing/BillingLimitConfigSection.tsx

@@ -126,6 +126,7 @@ export function BillingLimitConfigSection({
   const formRef = useRef<HTMLFormElement>(null);
 
   useEffect(() => {
+    // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes local state after an external or lifecycle change.
     setMode(resetMode);
     setCustomAmount(savedCustomAmount);
     setCancelInProgressRuns(savedCancelInProgressRuns);