Commit 9e3df84
fix(webapp): drop the chip ring on the light themes where the chip fills solid
The contrast-chip ring is drawn in currentcolor. On a tinted chip that's the
accent, which is the edge it was written for; on a chip that fills solid the label
is white, so the ring is a white hairline inset into the fill. Against a dark page
that still reads as an edge, but on white it reads as a stray inner border.
Cancelled for the light themes only, and only for chips that actually fill - the
error badge's bright prominence, the queue health chips, and the Stronger colors
preview on the account page. A `contrast-chip-solid` marker carries that, because
the two remaining users (limits, private connections) stay tinted under the
preference and still want the ring.
The error badge marks only `bright`; `subtle` keeps its tint and its ring.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent dc61767 commit 9e3df84
5 files changed
Lines changed: 15 additions & 4 deletions
File tree
- apps/webapp/app
- components/errors
- routes
- _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues
- account._index
- storybook.colors
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1584 | 1584 | | |
1585 | 1585 | | |
1586 | 1586 | | |
1587 | | - | |
| 1587 | + | |
1588 | 1588 | | |
1589 | 1589 | | |
1590 | 1590 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
559 | 559 | | |
560 | 560 | | |
561 | 561 | | |
562 | | - | |
| 562 | + | |
563 | 563 | | |
564 | 564 | | |
565 | 565 | | |
| |||
1060 | 1060 | | |
1061 | 1061 | | |
1062 | 1062 | | |
1063 | | - | |
| 1063 | + | |
1064 | 1064 | | |
1065 | 1065 | | |
1066 | 1066 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
352 | 361 | | |
353 | 362 | | |
354 | 363 | | |
| |||
0 commit comments