Commit ae6aac8
fix(webapp): don't count the column layout as filters in favorite names
The runs URL now carries cols/sc/hide, and describeFilters counts any param it
doesn't recognise, so favoriting a view with customised columns named it
"Runs: 3 filters" and added an inflated "+N" to genuinely filtered views. The
layout is presentation, not a filter, so it joins NON_FILTER_PARAMS.
The three param names were repeated as literals across four files, so they now
come from one exported list in the column registry.
Reported by Devin on the PR.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 8f09a9d commit ae6aac8
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| |||
366 | 367 | | |
367 | 368 | | |
368 | 369 | | |
369 | | - | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
370 | 378 | | |
371 | 379 | | |
372 | 380 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
154 | 160 | | |
155 | 161 | | |
156 | 162 | | |
| |||
0 commit comments