feat(webapp): management API for orgs, projects, members, and settings#4146
Draft
nicktrn wants to merge 6 commits into
Draft
feat(webapp): management API for orgs, projects, members, and settings#4146nicktrn wants to merge 6 commits into
nicktrn wants to merge 6 commits into
Conversation
…ites, and projects
… isSecret, default region, and environment pause/resume
…ull when unset) in project GET and list
🦋 Changeset detectedLatest commit: 9573c59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nicktrn
changed the title
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📜 Recent review details⏰ Context from checks skipped due to timeout. (18)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description gives a strong summary, but it omits required template sections like Closes #issue, checklist, Testing, Changelog, and Screenshots. |
Add the missing template sections: Closes #issue, checklist items, testing steps, changelog, and screenshots placeholders. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the main change: a new PAT-based management API for orgs, projects, members, and settings. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
feat/local-management-api-tri-11579
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts (1)
1-74: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract shared logic across pause/resume/regenerate-api-key routes.
ParamsSchema, the auth flow (lines 18-60), and the authorization gate are duplicated verbatim across all three route files. Consolidating into a shared helper (e.g.,resolveEnvironmentForApiAction(request, params)returning{ environment } | Response) would reduce drift risk as these routes evolve.♻️ Sketch of shared helper
+// ~/services/environmentApiRoute.server.ts +export async function resolveEnvironmentForWriteAction( + request: Request, + params: unknown +): Promise<{ environment: AuthenticatedEnvironment } | Response> { + const parsedParams = ParamsSchema.safeParse(params); + if (!parsedParams.success) { + return json({ error: "Invalid Params" }, { status: 400 }); + } + const { projectRef, env } = parsedParams.data; + + const authenticationResult = await authenticateRequest(request, { + personalAccessToken: true, + organizationAccessToken: false, + apiKey: false, + }); + if (!authenticationResult) { + return json({ error: "Invalid or Missing Access Token" }, { status: 401 }); + } + + const environment = await authenticatedEnvironmentForAuthentication( + authenticationResult, + projectRef, + env, + branchNameFromRequest(request) + ); + + const denied = await authorizePatEnvironmentAccess({ + request, + authType: authenticationResult.type, + organizationId: environment.organizationId, + projectId: environment.project.id, + envType: environment.type, + resource: "apiKeys", + action: "write", + }); + if (denied) return denied; + + return { environment }; +}
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f4d3e251-f0cd-483a-bd52-87f2088be62e
📒 Files selected for processing (17)
.changeset/project-default-region-response.mdapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/services/organizationApiAccess.server.tspackages/core/src/v3/schemas/api.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (29)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - pnpm)
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: typecheck / typecheck
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
⚠️ CI failures not shown inline (2)
GitHub Actions: 🛡️ E2E Tests: Webapp Auth (full) / 0_🛡️ E2E Auth Tests (full).txt: feat(webapp): management API for orgs, projects, members, and settings
Conclusion: failure
localhost","method":"GET","abortController":{}},"timestamp":"","name":"webapp","message":"Network error:","level":"error","traceId":"eb2ff3df92b573c459f512402212a7d2","parentSpanId":"9f0535a39b8d1bc9"}
GET /realtime/v1/runs?tags=foo,bar 503 - - 3.723 ms
{"traceId":"eb2ff3df92b573c459f512402212a7d2","message":"GET","spanId":"9f0535a39b8d1bc9","kind":1,"timestamp":1783093693997000,"duration":4304.662,"attributes":{"http.url":"http://localhost:35835/realtime/v1/runs?tags=foo,bar","http.host":"localhost:35835","net.host.name":"localhost","http.method":"GET","http.scheme":"http","http.target":"/realtime/v1/runs?tags=foo,bar","http.user_agent":"node","http.flavor":"1.1","net.transport":"ip_tcp","db.datasource":"writer","net.host.ip":"::ffff:127.0.0.1","net.host.port":35835,"net.peer.ip":"::ffff:127.0.0.1","net.peer.port":40104,"http.status_code":503,"http.status_text":"SERVICE UNAVAILABLE"},"status":{"code":2},"events":[],"links":[],"level":"trace"}
GET /realtime/v1/runs?tags=foo 403 - - 2.693 ms
{"error":"fetch failed","http":{"requestId":"H7Haaqdn0lcDArbMFZAeu","path":"/realtime/v1/runs","host":"localhost","method":"GET","abortController":{}},"timestamp":"","name":"webapp","message":"Network error:","level":"error"}
GET /realtime/v1/runs 503 - - 3.065 ms
GET /realtime/v1/runs 403 - - 2.638 ms
POST /api/v2/runs/run_anything/cancel 401 215 - 0.153 ms
POST /api/v2/runs/run_anything/cancel 401 - - 4.994 ms
{"traceId":"00d7fa453a0cf43a97cc0d5aae791607","message":"POST","spanId":"05f7b15d27a812d4","kind":1,"timestamp":1783093694027000,"duration":5398.22,"attributes":{"http.url":"http://localhost:35835/api/v2/runs/run_anything/cancel","http.host":"localhost:35835","net.host.name":"localhost","http.method":"POST","http.scheme":"http","http.target":"/api/v2/runs/run_anything/cancel","http.user_agent":"node","http.request_content_length_uncompressed":2,"http.flavor":"1.1","net.transport":"ip_tcp","db.datasource":"writer","net.host.ip":"::ffff:127.0.0.1","net.host.port...
GitHub Actions: 🛡️ E2E Tests: Webapp Auth (full) / 🛡️ E2E Auth Tests (full): feat(webapp): management API for orgs, projects, members, and settings
Conclusion: failure
nc ClickHouseRunsRepository.listRunIds (/home/runner/_work/trigger.dev/trigger.dev/apps/webapp/build/index.js:107598:20)\n at async ClickHouseRunsRepository.listRuns (/home/runner/_work/trigger.dev/trigger.dev/apps/webapp/build/index.js:107629:38)\n at async /home/runner/_work/trigger.dev/trigger.dev/apps/webapp/build/index.js:25770:14\n at async NextRunListPresenter.call (/home/runner/_work/trigger.dev/trigger.dev/apps/webapp/build/index.js:146463:39)\n at async /home/runner/_work/trigger.dev/trigger.dev/apps/webapp/build/index.js:248449:21"},"url":"http://localhost:35835/api/v1/runs?filter%5BtaskIdentifier%5D=task_a%2Ctask_b","http":{"requestId":"2W-2TOvLULjNNq2ta-9He","path":"/api/v1/runs?filter%5BtaskIdentifier%5D=task_a%2Ctask_b","host":"localhost","method":"GET","abortController":{}},"timestamp":"","name":"webapp","message":"Error in loader","level":"error"}
GET /api/v1/runs?filter%5BtaskIdentifier%5D=task_a%2Ctask_b 500 - - 9.307 ms
GET /api/v1/runs?filter%5BtaskIdentifier%5D=task_a 403 - - 4.849 ms
{"traceId":"9b70066ad54b81f5d27545389bd98739","message":"GET","spanId":"1a8a3972b4b944b3","kind":1,"timestamp":1783093693970000,"duration":5437.591,"attributes":{"http.url":"http://localhost:35835/api/v1/runs?filter%5BtaskIdentifier%5D=task_a","http.host":"localhost:35835","net.host.name":"localhost","http.method":"GET","http.scheme":"http","http.target":"/api/v1/runs?filter%5BtaskIdentifier%5D=task_a","http.user_agent":"node","http.flavor":"1.1","net.transport":"ip_tcp","db.datasource":"writer","net.host.ip":"::ffff:127.0.0.1","net.host.port":35835,"net.peer.ip":"::ffff:127.0.0.1","net.peer.port":40104,"http.status_code":403,"http.status_text":"FORBIDDEN"},"status":{"code":0},"events":[],"links":[],"level":"trace"}
GET /realtime/v1/runs 401 - - 1.143 ms
{"error":"fetch failed","http":{"requestId":"MtGOdPb1wxJrk3Qc6mQ4s","path":"/realtime/v1/runs","host":"localhost","method":"GET","abortController":{}},"timestamp":"","name":"webapp","message":"...
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/services/organizationApiAccess.server.ts
packages/core/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (packages/core/CLAUDE.md)
Never import the root package (
@trigger.dev/core). Always use subpath imports such as@trigger.dev/core/v3,@trigger.dev/core/v3/utils,@trigger.dev/core/logger, or@trigger.dev/core/schemas
Files:
packages/core/src/v3/schemas/api.ts
packages/**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Use
pnpm run buildto verify changes in public packages (packages/*).
Files:
packages/core/src/v3/schemas/api.ts
🧠 Learnings (13)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.tsapps/webapp/app/services/organizationApiAccess.server.tsapps/webapp/app/routes/api.v1.orgs.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.projects.tsapps/webapp/app/routes/api.v1.projects.$projectRef.default-region.tsapps/webapp/app/routes/api.v1.projects.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.invites.tsapps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.tsapps/webapp/app/routes/api.v1.projects.$projectRef.tspackages/core/src/v3/schemas/api.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/organizationApiAccess.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/services/organizationApiAccess.server.ts
🔇 Additional comments (26)
apps/webapp/app/routes/api.v1.projects.$projectRef.envvars.$slug.ts (1)
65-65: LGTM!apps/webapp/app/services/organizationApiAccess.server.ts (1)
18-78: LGTM!apps/webapp/app/routes/api.v1.orgs.$orgParam.members.ts (1)
16-83: LGTM!apps/webapp/app/routes/api.v1.orgs.$orgParam.members.$memberId.ts (1)
18-86: LGTM!apps/webapp/app/routes/api.v1.orgs.$orgParam.invites.ts (1)
23-99: LGTM!apps/webapp/app/routes/api.v1.orgs.$orgParam.invites.$inviteId.ts (1)
17-69: LGTM!apps/webapp/app/routes/api.v1.orgs.$orgParam.ts (1)
37-65: 🎯 Functional CorrectnessDelete/rename are membership-scoped. Both the API route and the dashboard settings action gate these on org membership, not an admin/owner role.
apps/webapp/app/routes/api.v1.projects.$projectRef.$env.resume.ts (3)
49-59: 🔒 Security & PrivacySame RBAC resource concern as
pause.ts.This route reuses the identical
apiKeys/writegate for resuming an environment; see the corresponding comment onapps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts(Lines 49-59).
62-62: 🔒 Security & PrivacySame missing actor/userId concern as
pause.ts.See the corresponding comment on
apps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts(Line 62) aboutPauseEnvironmentService.calllacking actor attribution.
1-74: 📐 Maintainability & Code QualityDuplicate of pause.ts logic.
See the DRY-extraction comment on
apps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts(Lines 1-74).apps/webapp/app/routes/api.v1.projects.$projectRef.$env.regenerate-api-key.ts (2)
49-59: 🔒 Security & PrivacySame RBAC resource concern noted for pause/resume.
Here
apiKeys/writeis semantically correct for rotating a key. See the sibling comment onpause.tsabout the same gate being reused for a differently-scoped action (pause/resume).
1-73: 📐 Maintainability & Code QualityDuplicate scaffolding vs. pause/resume routes.
See the DRY-extraction comment on
apps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts(Lines 1-74);userIdis correctly passed here toregenerateApiKey, unlike the pause/resume routes.apps/webapp/app/routes/api.v1.projects.$projectRef.$env.pause.ts (3)
18-27: LGTM!Also applies to: 31-41, 64-73
62-62: 🔒 Security & Privacy
PauseEnvironmentService.calldoesn't take an actor/userId. This route matches the service API, and the same call shape is used in the other pause/resume paths.> Likely an incorrect or invalid review comment.
49-59: 🔒 Security & Privacy
apiKeys/writeis the intended env-tier gatePause/resume uses the same
apiKeys/writecheck as the other env-scoped API actions, so this is consistent with the current RBAC model.> Likely an incorrect or invalid review comment.apps/webapp/app/routes/api.v1.projects.ts (1)
31-34: LGTM!Also applies to: 41-54
.changeset/project-default-region-response.md (1)
1-6: LGTM!apps/webapp/app/routes/api.v1.projects.$projectRef.ts (3)
103-114: 🔒 Security & PrivacySame membership-only authorization gap as
default-region.ts.DELETE/PATCH here resolve the project via org membership only, without the ability/role check used by
authorizePatOrganizationAccessfor other org-scoped resources. Same concern flagged inapi.v1.projects.$projectRef.default-region.ts(lines 41-55) — worth confirmingDeleteProjectService/ProjectSettingsServiceindependently enforce sufficient authorization for these destructive actions.
116-145: 🎯 Functional CorrectnessSame malformed-JSON-returns-500 pattern as
default-region.ts.
request.json()at line 126 is unguarded inside the outer try/catch, so invalid JSON bodies surface as 500 instead of 400. Same issue and fix flagged inapi.v1.projects.$projectRef.default-region.ts.Also applies to: 126-126
1-9: LGTM!Also applies to: 15-75, 77-102
apps/webapp/app/routes/api.v1.projects.$projectRef.default-region.ts (3)
1-32: LGTM!Also applies to: 63-100
41-55: 🔒 Security & PrivacyNo issue: the default-region path already enforces region access rules.
RegionsPresenterfilters the selectable regions, andSetDefaultRegionServicerechecks allowed queues / hidden / compute-access rules before updating the project.> Likely an incorrect or invalid review comment.
3-3: 🎯 Functional Correctness
@trigger.dev/core/utilsalready exportstryCatch; no change needed.> Likely an incorrect or invalid review comment.apps/webapp/app/routes/api.v1.orgs.$orgParam.projects.ts (1)
44-44: LGTM!Also applies to: 58-58, 122-139
packages/core/src/v3/schemas/api.ts (2)
30-49: 🗄️ Data Integrity & Integration | ⚡ Quick winConsider making
defaultRegionoptional for forward/backward compatibility.
defaultRegionisnullable()but required. Any consumer parsing a response from a webapp instance that hasn't yet been upgraded to populate this field (rolling deploys, version-skewed self-hosted installs) will fail schema validation. Making it.optional().nullable()(or providing a.default(null)) would avoid breaking older/newer version combinations across this API boundary.💡 Proposed fix
- defaultRegion: z.string().nullable(), + defaultRegion: z.string().nullable().optional(),
1229-1238: LGTM!
Collaborator
Author
|
Thanks for the review. Addressed the two actionable items: malformed/empty JSON now returns 400 (not 500) across all five new handlers (9573c59). On the nitpick to extract a shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a set of PAT-authenticated management API endpoints so orgs, projects, members/invites, environment variables, and a few project/environment settings can be managed programmatically (scripting, automation) rather than only through the dashboard. Each route is a thin wrapper over the existing service the dashboard already uses, with the same authorization applied at the route layer - no new business logic.
Endpoints
Organizations
POST /api/v1/orgs- create an org (createOrganization)PATCH /api/v1/orgs/:orgParam- rename (title)DELETE /api/v1/orgs/:orgParam- soft-delete (DeleteOrganizationService; keeps the active-subscription guard)Members & invites
GET /api/v1/orgs/:orgParam/members- list members + pending invitesDELETE /api/v1/orgs/:orgParam/members/:memberId- remove a member (last-member guarded)POST /api/v1/orgs/:orgParam/invites- invite by email (inviteMembers, sends the invite email)DELETE /api/v1/orgs/:orgParam/invites/:inviteId- revoke an inviteProjects
PATCH /api/v1/projects/:projectRef- rename (ProjectSettingsService)DELETE /api/v1/projects/:projectRef- soft-delete (DeleteProjectService)PUT /api/v1/projects/:projectRef/default-region- set the default region by worker-group name (SetDefaultRegionService)defaultRegion(worker-group name, or null when unset)Environments
POST /api/v1/projects/:projectRef/:env/pauseand/resume(PauseEnvironmentService)POST /api/v1/projects/:projectRef/:env/regenerate-api-key- rotate the env secret key (regenerateApiKey, RBACwrite:apiKeys)isSecretflagAuth & authorization
Authorization: Bearer tr_pat_...), following the existingapi.v1.orgs.tspattern.organizationApiAccess.server.ts): membership resolution as the floor, plusread:members/manage:membersability checks. Env-tier routes reuse the existingauthorizePatEnvironmentAccess.Notes for reviewers
@trigger.dev/coregets one additive field (defaultRegionon the project response) - changeset included, patch.