Replace grid-based gap fill with edge-based algorithm & and remove the old gapfill#27
Closed
0hmX wants to merge 5 commits intotscircuit:mainfrom
Closed
Replace grid-based gap fill with edge-based algorithm & and remove the old gapfill#270hmX wants to merge 5 commits intotscircuit:mainfrom
0hmX wants to merge 5 commits intotscircuit:mainfrom
Conversation
- Remove GapFillSubSolver and all grid-based gap detection code - Remove old gap fill engine files (stepGapFill, initGapFillState, etc.) - Remove gap detection algorithms (findAllGaps, findGapsOnLayer, etc.) - Keep only utility functions (calculateCoverage, findUncoveredPoints)
- Create BasePipelineSolver abstract class - Provides standard pattern for multi-phase solvers - Handles phase transitions and step execution - Abstract methods: getCurrentPhase, setPhase, stepPhase
- Implement edge extraction from placed rectangles - Find nearby parallel edges within distance threshold - Detect unoccupied segments along edges - Generate expansion points outside unoccupied segments - Extremely granular stages for visualization: * SELECT_EDGE: Select primary edge * FIND_NEARBY: Find nearby parallel edges * FIND_SEGMENTS: Find unoccupied segments * GENERATE_POINTS: Generate expansion points * EXPAND_FROM_POINT: Expand rectangles from points
- Convert RectDiffSolver to use BasePipelineSolver - Integrate edge-based gap fill in GAP_FILL phase - Add comprehensive visualization for gap fill stages: * Primary edge (red), nearby edges (orange) * Unoccupied segments (green), expansion points (blue/red) * Expanding rectangles (yellow) - Export buildHardPlacedByLayer for gap fill use
- Remove GapFillOptions, GapRegion, GapFillState types - Keep only LayerContext for utility functions - Update engine exports to only include utility functions
|
@0hmX is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
0hmX
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.