Skip to content

Commit 09eab16

Browse files
committed
fix(demo): analyze conflicts by directory overlap, not fileoverlap
`fileoverlap` was renamed to `pathoverlap` with a `by: file | directory` granularity in #575, and the orchestrator's config loader rejects an unrecognised analyzer type outright — `unknown analyzer type %q` in `normalizeAndValidate` — so the demo profile would have failed at startup rather than quietly falling back to a default. Picks `by: directory` rather than the `by: file` that matches the old name. The demo spreads each change over a sharded file tree, so keying on the immediate parent directory gives the queue real dependency chains to show while still landing changes in different folders in parallel. Directory overlap is strictly coarser than file overlap: every file overlap is also a directory overlap, and files at the repository root all share one key.
1 parent 0d02d22 commit 09eab16

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

service/submitqueue/demo/provider/github/profiles.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,13 @@ queues:
1717
# Enterprise, add `github: {baseUrl: https://ghe.example.com/api/v3}`.
1818
changeProvider: {type: github}
1919

20-
# Serializes only batches that touch a shared file, so independent changes
21-
# land in parallel. Swap for {type: all} to serialize the queue entirely, or
22-
# {type: none} for maximum parallelism with no conflict detection.
23-
analyzer: {type: fileoverlap}
20+
# Serializes batches that touch a shared directory, so changes land in
21+
# parallel unless they land in the same folder. Keys on the immediate parent
22+
# directory, and files at the repository root all share one key. Use
23+
# `by: file` to conflict only on the same file, {type: all} to serialize the
24+
# queue entirely, or {type: none} for maximum parallelism with no conflict
25+
# detection.
26+
analyzer: {type: pathoverlap, by: directory}
2427

2528
# Every build succeeds instantly, so a land completes in seconds and the
2629
# demo exercises the merge rather than waiting on CI.

0 commit comments

Comments
 (0)