tests: speed up tests by having cassandra fixtures be 'class' scoped

Author: Hyask

src/tests/conftest.py

@@ -20,7 +20,7 @@
 from errortracker import cassandra
 
 
-@pytest.fixture(scope="function")
+@pytest.fixture(scope="class")
 def temporary_db():
     cassandra.KEYSPACE = "tmp"
     cassandra.REPLICATION_FACTOR = 1
@@ -29,7 +29,7 @@ def temporary_db():
     management.drop_keyspace(cassandra.KEYSPACE)
 
 
-@pytest.fixture(scope="function")
+@pytest.fixture(scope="class")
 def retracer(temporary_db):
     temp = Path(tempfile.mkdtemp())
     config_dir = temp / "config"
@@ -54,11 +54,12 @@ def datetime_now():
     return datetime.now()
 
 
-@pytest.fixture(scope="function")
+@pytest.fixture(scope="class")
 def cassandra_data(datetime_now, temporary_db):
-    import bson
     import logging
 
+    import bson
+
     from daisy.submit import submit
 
     # disable daisy logger temporarily
@@ -105,15 +106,15 @@ def new_oops(days_ago, data, systemid="imatestsystem"):
     # no-crashes-today package version 1 (old version with crashes)
     for i in [30, 20, 10, 5, 2]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "no-crashes-today 1", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/no-crashes-today", "StacktraceAddressSignature": "/usr/bin/no-crashes-today:1:/usr/bin/no-crashes-today+10"})
-    
+
     # no-crashes-today package version 2 (no crashes today - last crash was yesterday)
     for i in [5, 3, 1]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "no-crashes-today 2", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/no-crashes-today", "StacktraceAddressSignature": "/usr/bin/no-crashes-today:2:/usr/bin/no-crashes-today+20"})
 
     # few-crashes package version 1 (old version with crashes)
     for i in [30, 20, 10, 5, 2]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "few-crashes 1", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/few-crashes", "StacktraceAddressSignature": "/usr/bin/few-crashes:1:/usr/bin/few-crashes+10"})
-    
+
     # few-crashes package version 2 (only 2 crashes today - less than threshold of 3)
     for i in [0, 0]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "few-crashes 2", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/few-crashes", "StacktraceAddressSignature": "/usr/bin/few-crashes:2:/usr/bin/few-crashes+20"})
@@ -125,7 +126,7 @@ def new_oops(days_ago, data, systemid="imatestsystem"):
     # low-difference package version 1 (old version with consistent crashes)
     for i in [30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "low-difference 1", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/low-difference", "StacktraceAddressSignature": "/usr/bin/low-difference:1:/usr/bin/low-difference+10"})
-    
+
     # low-difference package version 2 (similar crash rate to version 1, so difference should be low)
     # Only 1 crash today which is less than the expected average
     for i in [0]:
@@ -134,7 +135,7 @@ def new_oops(days_ago, data, systemid="imatestsystem"):
     # all-proposed package version 1
     for i in [30, 20, 10]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "all-proposed 1", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/all-proposed", "StacktraceAddressSignature": "/usr/bin/all-proposed:1:/usr/bin/all-proposed+10"})
-    
+
     # all-proposed package version 2 (all crashes today are from proposed)
     for i in [0, 0, 0, 0]:
         new_oops(i, {"DistroRelease": "Ubuntu 24.04", "Package": "all-proposed 2", "ProblemType": "Crash", "Architecture": "amd64", "ExecutablePath": "/usr/bin/all-proposed", "StacktraceAddressSignature": "/usr/bin/all-proposed:2:/usr/bin/all-proposed+20", "Tags": "package-from-proposed"})

src/tests/test_oopses.py

@@ -102,7 +102,7 @@ def _test_insert_check(self, oopsid, day_key, value=None):
         assert value == result["duration"]
         # The oops has been indexed by day
         oops_refs = cassandra_schema.DayOOPS.filter(key=day_key.encode()).only(["value"])
-        assert [oopsid] == [day_oops.value.decode() for day_oops in oops_refs]
+        assert oopsid in [day_oops.value.decode() for day_oops in oops_refs]
         # TODO - the aggregates for the OOPS have been updated.
 
     def test_insert_oops_dict(self, temporary_db):
@@ -124,12 +124,12 @@ def test_insert_updates_counters(self, temporary_db):
 
         day_key = oopses.insert_dict(oopsid, oops, user_token)
         oops_count = cassandra_schema.Counters.filter(key=b"oopses", column1=day_key)
-        assert [1] == [count.value for count in oops_count]
+        assert [3] == [count.value for count in oops_count]
 
         oopsid = str(uuid.uuid1())
         day_key = oopses.insert_dict(oopsid, oops, user_token)
         oops_count = cassandra_schema.Counters.filter(key=b"oopses", column1=day_key)
-        assert [2] == [count.value for count in oops_count]
+        assert [4] == [count.value for count in oops_count]
 
 
 class TestBucket: