sha256sum/sha1sum fail if file contains mixed-hash types

[Inndy]

When a checksum file contains different type of hashes, running sha256sum -c CHECKSUMS will fail.

coreutils would report sha256sum: WARNING: 4 lines are improperly formatted and return exit code 0.

# Checksums, check with the command below:
#     shasum -c CHECKSUMS
#
# Checksums-Sha1:
16884dd63beb3349acf3cae4d2d592d4724751f1  linux-headers-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb
4df410365485b1214689c4aea433ca852dd5b01a  linux-headers-6.18.14-061814_6.18.14-061814.202602262345_all.deb
809697f1a23338fb10d9812cf1f8be509b2ee608  linux-image-unsigned-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb
5e841b4ff3708a8db05c7c4e9f4e723e0927dd92  linux-modules-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb
#
# Checksums-Sha256:
eb4f751b84693e731f9497a4a5913b4e1eef7a60b853d1185d5214932fdbb588  linux-headers-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb
bf9f50363eba0f9cd9c9fbd61b930857aa75d46945aa584cdc8cdcb92cb76573  linux-headers-6.18.14-061814_6.18.14-061814.202602262345_all.deb
e31a9b827a165b0d685f3306cdedf8f6d9ef27b694b37f832af8db023c0523b6  linux-image-unsigned-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb
e34c69bd2cfa07ae0a6aa538a498ac3c4ca82404b71232a2fff00e754f756a9f  linux-modules-6.18.14-061814-generic_6.18.14-061814.202602262345_amd64.deb

Thank you rewrite everything in rust guys for amazing breaking changes and wasting my time.

[oech3]

It is same with GNU 9.10. You should use cksum -c for mixed formats.

[sylvestre]

invalid bug

[cakebaker]

It's a valid bug.

Here are the steps to reproduce.

Create the sha1 and sha256 hashes of a file (our README.md in this example):

$ cksum -a sha1 README.md 
SHA1 (README.md) = afb210d567de18b5c351265312dca524f67e8d5c
$ cksum -a sha256 README.md 
SHA256 (README.md) = 506a6b5b669fdd11fa41b3d7fbda68be54898cae5d890fc8b47d9c283b0e97aa

Create a file with the two hashes (checksums.txt in this example):

afb210d567de18b5c351265312dca524f67e8d5c  README.md
506a6b5b669fdd11fa41b3d7fbda68be54898cae5d890fc8b47d9c283b0e97aa  README.md

Check the checksums with our implementation (using main):

$ cargo run -q sha256sum -c checksums.txt 
README.md: FAILED
README.md: OK
sha256sum: WARNING: 1 computed checksum did NOT match
$ echo $?
1

And with GNU sha256sum:

$ sha256sum -c checksums.txt 
README.md: OK
sha256sum: WARNING: 1 line is improperly formatted
$ echo $?
0

The output is similar if you use cksum -c -a sha256 checksums.txt (or cksum -c -a sha1 checksums.txt) instead.

If an algorithm is specified that's not used in the file, both implementations fail. However, GNU cksum doesn't output anything to stdout, whereas we do:

$ cargo run -q cksum -c -a sha512 checksums.txt 
README.md: FAILED
README.md: FAILED
cksum: WARNING: 2 computed checksums did NOT match
$ echo $?
1
$ cksum -c -a sha512 checksums.txt 
cksum: checksums.txt: no properly formatted checksum lines found
$ echo $?
1

And if no algorithm is specified, both implementations fail:

$ cargo run -q cksum -c checksums.txt 
cksum: checksums.txt: no properly formatted checksum lines found
$ echo $?
1
$ cksum -c checksums.txt 
cksum: checksums.txt: no properly formatted checksum lines found
$ echo $?
1