Pass arguments as const Value*

Author: chfast

lib/fizzy/execute.cpp

@@ -81,7 +81,7 @@ inline bool invoke_function(const FuncType& func_type, uint32_t func_idx, Instan
     OperandStack& stack, int depth) noexcept
 {
     const auto func = [func_idx](Instance& _instance, span<const Value> args, int _depth) noexcept {
-        return execute(_instance, func_idx, args.begin(), _depth);
+        return execute(_instance, func_idx, args.data(), _depth);
     };
     return invoke_function(func_type, func, instance, stack, depth);
 }

lib/fizzy/instantiate.cpp

@@ -328,7 +328,7 @@ std::unique_ptr<Instance> instantiate(Module module,
         for (const auto idx : instance->module.elementsec[i].init)
         {
             auto func = [idx, &instance_ref = *instance](fizzy::Instance&, span<const Value> args,
-                            int depth) { return execute(instance_ref, idx, args.begin(), depth); };
+                            int depth) { return execute(instance_ref, idx, args.data(), depth); };
 
             *it_table++ =
                 ExternalFunction{std::move(func), instance->module.get_function_type(idx)};
@@ -433,7 +433,7 @@ std::optional<ExternalFunction> find_exported_function(Instance& instance, std::
 
     const auto idx = *opt_index;
     auto func = [idx, &instance](fizzy::Instance&, span<const Value> args, int depth) {
-        return execute(instance, idx, args.begin(), depth);
+        return execute(instance, idx, args.data(), depth);
     };
 
     return ExternalFunction{std::move(func), instance.module.get_function_type(idx)};

test/unittests/execute_call_test.cpp

@@ -338,7 +338,7 @@ TEST(execute_call, imported_function_from_another_module)
     ASSERT_TRUE(func_idx.has_value());
 
     auto sub = [&instance1, func_idx](Instance&, span<const Value> args, int) -> ExecutionResult {
-        return fizzy::execute(*instance1, *func_idx, args.begin());
+        return fizzy::execute(*instance1, *func_idx, args.data());
     };
 
     auto instance2 = instantiate(module2, {{sub, module1.typesec[0]}});