Use mediawiki-phan-config 0.16.0

The majority of issues were related to exception handling (unused
exception variable, missing @throws annotation etc), and straightforward
to fix.

Bug: T398459
Change-Id: I5a459fd4c45eb73439ade6cca29109370468a495

Author: jakobw

src/DataValue/ValuesFinder.php

@@ -67,7 +67,7 @@ public function findFromSnaks( array $snaks, $dataType ) {
 	private function isMatchingDataType( PropertyId $propertyId, $dataType ) {
 		try {
 			return $this->propertyDataTypeLookup->getDataTypeIdForProperty( $propertyId ) === $dataType;
-		} catch ( PropertyDataTypeLookupException $ex ) {
+		} catch ( PropertyDataTypeLookupException ) {
 			return false;
 		}
 	}

src/Entity/PropertyDataTypeMatcher.php

@@ -36,7 +36,7 @@ public function __construct( PropertyDataTypeLookup $propertyDataTypeLookup ) {
 	public function isMatchingDataType( PropertyId $propertyId, $dataType ) {
 		try {
 			return $this->findDataTypeIdForProperty( $propertyId ) === $dataType;
-		} catch ( PropertyDataTypeLookupException $ex ) {
+		} catch ( PropertyDataTypeLookupException ) {
 			return false;
 		}
 	}

src/EntityId/EntityIdLabelFormatter.php

@@ -51,7 +51,7 @@ public function formatEntityId( EntityId $entityId ) {
 	protected function lookupEntityLabel( EntityId $entityId ) {
 		try {
 			return $this->labelLookup->getLabel( $entityId );
-		} catch ( LabelDescriptionLookupException $e ) {
+		} catch ( LabelDescriptionLookupException ) {
 			return null;
 		}
 	}

src/Lookup/ExceptionIgnoringEntityLookup.php

@@ -33,7 +33,7 @@ public function __construct( EntityLookup $lookup ) {
 	public function getEntity( EntityId $entityId ) {
 		try {
 			return $this->lookup->getEntity( $entityId );
-		} catch ( EntityLookupException $exception ) {
+		} catch ( EntityLookupException ) {
 			return null;
 		}
 	}

src/Statement/Filter/DataTypeStatementFilter.php

@@ -54,7 +54,7 @@ public function statementMatches( Statement $statement ) {
 
 		try {
 			$dataType = $this->dataTypeLookup->getDataTypeIdForProperty( $id );
-		} catch ( PropertyDataTypeLookupException $ex ) {
+		} catch ( PropertyDataTypeLookupException ) {
 			return false;
 		}
 

src/Statement/StatementGuidValidator.php

@@ -98,7 +98,7 @@ private function validateStatementGuidPrefix( $prefixedId ) {
 		try {
 			$this->entityIdParser->parse( $prefixedId );
 			return true;
-		} catch ( EntityIdParsingException $ex ) {
+		} catch ( EntityIdParsingException ) {
 			return false;
 		}
 	}