feat(p2p/sensor): validate block signer before rebroadcast#946
Draft
minhd-vu wants to merge 1 commit into
Draft
Conversation
When block rebroadcasting is enabled, the sensor now only rebroadcasts blocks whose recovered signer is in the current Heimdall validator set. Blocks from unknown signers are still persisted and their bodies are still requested; they are simply not propagated to peers. - Add ValidatorSet (p2p/validators.go): fetches /stake/validators-set from Heimdall, blocking initial load + periodic refresh, IsAuthorized. - Add Conns.IsKnownSigner to gate rebroadcast by recovered signer. - Gate handleNewBlock; defer block-hash rebroadcast from handleNewBlockHashes to handleBlockHeaders so the fetched header can be validated first (body requests stay ungated). - Consolidate util.Ecrecover to take *types.Header. - Add --heimdall-url and --validator-set-refresh sensor flags.
minhd-vu
force-pushed
the
feat/sensor-validate-block-signer
branch
from
b028f73 to
60d7cc3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When block rebroadcasting is enabled, the sensor now only rebroadcasts blocks whose recovered signer is in the current Heimdall validator set. Blocks from unknown signers are still persisted and their bodies are still requested; they are simply not propagated to peers.
ValidatorSet(p2p/validators.go): fetches/stake/validators-setfrom Heimdall, blocking initial load + periodic refresh, IsAuthorized.Conns.IsKnownSignerto gate rebroadcast by recovered signer.handleNewBlock; defer block-hash rebroadcast fromhandleNewBlockHashestohandleBlockHeadersso the fetched header can be validated first (body requests stay ungated).util.Ecrecoverto take*types.Header.--heimdall-urland--validator-set-refreshsensor flags.Jira / Linear Tickets
Testing