fix: disable favorite toggle during sort mode and fix drag rebound issue#12026
fix: disable favorite toggle during sort mode and fix drag rebound issue#12026rowanchen-com wants to merge 3 commits into1Panel-dev:dev-v2from
Conversation
…n during sorting, and optimize sorting behavior caused by DOM conflicts.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
fix: prevent app icon from being squished in detail drawer |
What this PR does / why we need it?
Fix two issues with the installed app sorting feature added in #11936:
sort_orderrecalculation andsearch()reload, which resets the drag-sorted order and breaks the Sortable fence logic.Summary of your change
Disable favorite during sort mode (3 files, 6 changes):
index.vue: PasssortModeprop to AppCardcard.vue: AddsortModeprop, pass it to AppHeaderheader.vue: AddsortModeprop, set:disabled="sortMode"on both StarFilled and Star favorite buttonsFix drag rebound (1 file, 3 lines):
index.vue: InonEndcallback, revert Sortable's DOM manipulation before updatingdata.value, so Vue is the sole DOM owner and diff/patch works correctlyFiles changed: 3 (frontend only)
Please indicate you've done the following: