Skip to content

fix: disable favorite toggle during sort mode and fix drag rebound issue#12026

Open
rowanchen-com wants to merge 3 commits into1Panel-dev:dev-v2from
rowanchen-com:dev-v2
Open

fix: disable favorite toggle during sort mode and fix drag rebound issue#12026
rowanchen-com wants to merge 3 commits into1Panel-dev:dev-v2from
rowanchen-com:dev-v2

Conversation

@rowanchen-com
Copy link
Contributor

What this PR does / why we need it?

Fix two issues with the installed app sorting feature added in #11936:

  1. Toggling favorite during sort mode triggers backend sort_order recalculation and search() reload, which resets the drag-sorted order and breaks the Sortable fence logic.
  2. Dragging cards occasionally "rebounds" back to their original position due to Sortable.js and Vue both manipulating the DOM simultaneously.

Summary of your change

Disable favorite during sort mode (3 files, 6 changes):

  • index.vue: Pass sortMode prop to AppCard
  • card.vue: Add sortMode prop, pass it to AppHeader
  • header.vue: Add sortMode prop, set :disabled="sortMode" on both StarFilled and Star favorite buttons

Fix drag rebound (1 file, 3 lines):

  • index.vue: In onEnd callback, revert Sortable's DOM manipulation before updating data.value, so Vue is the sole DOM owner and diff/patch works correctly

Files changed: 3 (frontend only)

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

…n during sorting, and optimize sorting behavior caused by DOM conflicts.
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 2, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rowanchen-com
Copy link
Contributor Author

fix: prevent app icon from being squished in detail drawer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant