fix: add PostgreSQL recreation and DB host env sync in app restore#12029
fix: add PostgreSQL recreation and DB host env sync in app restore#12029
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db27bafe5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err := fileOp.TarGzExtractPro(tmpPath+"/app.tar.gz", tmpPath, ""); err != nil { | ||
| return err |
There was a problem hiding this comment.
If TarGzExtractPro(tmpPath+"/app.tar.gz", ...) fails (for example, incomplete or corrupted backup), this early return happens before the defer that runs compose.Up, so the app can remain stopped after recovery aborts. This is a regression because AppRecover has already executed compose.Down before calling handleAppRecover, and there is no other guaranteed restart path for this failure case.
Useful? React with 👍 / 👎.
ssongliu
force-pushed
the
songliu/app-recover-add-pg
branch
from
db27baf to
85fcf0d
Compare
|
2 participants
No description provided.