Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5eb318175d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if (globalStore.isXpackOrEE()) { | ||
| const xpackRes = await getXpackSetting(); | ||
| const [xpackRes, proxyDockerRes] = await Promise.all([getXpackSetting(), getXpackProxyDocker()]); |
There was a problem hiding this comment.
Using Promise.all here makes the entire search() flow reject when getXpackProxyDocker() fails (for example, transient API errors or version-skewed extension backends), even if getXpackSetting() succeeds. That leaves panel settings uninitialized for XPack/EE users, whereas the new proxyDocker value is optional and should degrade gracefully. Consider isolating this call (or using Promise.allSettled) so proxyDocker failure does not block the rest of the settings load.
Useful? React with 👍 / 👎.
2 participants
No description provided.