Chore: fix ci workflow #1178
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
==========================================
+ Coverage 41.84% 43.99% +2.14%
==========================================
Files 203 204 +1
Lines 20859 20925 +66
==========================================
+ Hits 8729 9205 +476
+ Misses 11350 10918 -432
- Partials 780 802 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
urbanikb
left a comment
There was a problem hiding this comment.
No problem with the PR, approved.
One question:
Update GH action and pin version by using sha
Would this not create maintenance burden / how were theseshapinned, is there a cli support for that inghor something like that?
|
It's security practice to pin with SHA, see https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions Regarding maintenance, we probably only need to upgrade the action once a year at most, unless something really broken. |
What