Skip to content

Chore: fix ci workflow #1178

Merged
tkan145 merged 3 commits into
3scale:masterfrom
tkan145:fix-ci
May 8, 2026
Merged

Chore: fix ci workflow #1178
tkan145 merged 3 commits into
3scale:masterfrom
tkan145:fix-ci

Conversation

@tkan145
Copy link
Copy Markdown
Contributor

@tkan145 tkan145 commented May 8, 2026

What

  • Bump builder image to go1.25
  • Update GH action and pin version by using sha
  • Ignore circleci test on master and all PR to master

@tkan145 tkan145 requested a review from a team as a code owner May 8, 2026 06:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.99%. Comparing base (4963add) to head (807385a).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   41.84%   43.99%   +2.14%     
==========================================
  Files         203      204       +1     
  Lines       20859    20925      +66     
==========================================
+ Hits         8729     9205     +476     
+ Misses      11350    10918     -432     
- Partials      780      802      +22     
Flag Coverage Δ
unit 43.99% <ø> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
apis/apps/v1alpha1 (u) 63.19% <ø> (+4.64%) ⬆️
apis/capabilities/v1alpha1 (u) 3.50% <ø> (ø)
apis/capabilities/v1beta1 (u) 20.21% <ø> (ø)
controllers (i) 12.08% <88.23%> (+2.76%) ⬆️
pkg (u) 63.69% <81.73%> (+1.97%) ⬆️
see 10 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@urbanikb urbanikb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with the PR, approved.

One question:

Update GH action and pin version by using sha
Would this not create maintenance burden / how were these sha pinned, is there a cli support for that in gh or something like that?

@tkan145
Copy link
Copy Markdown
Contributor Author

tkan145 commented May 8, 2026

It's security practice to pin with SHA, see https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Regarding maintenance, we probably only need to upgrade the action once a year at most, unless something really broken.

@tkan145 tkan145 merged commit c70208f into 3scale:master May 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants